Replace lib_phpQuery by PhpGt/CssXPath#4261
Conversation
|
Ping @marienfressinaud and @aledeg : if you use full content retrieval for some of your feeds, it would be nice if you could give this a try |
|
@javerous You did a a great work regarding full content retrieval #2778 ; so if you are around, it would be nice if you could give this PR a try, as there are risks of regressions :-) |
|
First glance it looks fine. Did not checked the code. |
| paths: | ||
| - . | ||
| excludePaths: | ||
| - lib/lib_phpQuery.php |
There was a problem hiding this comment.
should CssXPath be excluded from phpstan scan?
There was a problem hiding this comment.
Exclusion doesn't seem necessary if it's not causing issues, but potentially fair point from a handful of wasted cpu cycles.
There was a problem hiding this comment.
For now, I would rather keep it (phpstan uses some caching) to be informed in case of regression
For the few I had, it seems to work well 👍 (I prefer your approach rather than previous lib_phpQuery btw :)) |
Cool :-) Let's merge then |
Hi @Alkarex - sorry for the late reply. Thank you for your comment. I tested it a bit (even if the feature has been merged since a long time now…), I didn't notice any issues with the selectors I'm using ! The "HTML+XPath (Web scraping)" feature seems really cool ! I tested it a bit, it's very nice 👏 (and well, it may also deserve some way to validate / preview what was entered, in the future - it took me some time to have what I wanted 😅) |
|
Thanks for the feedback @javerous :-) |
https://github.com/PhpGt/CssXPath
Much lighter and cleaner