Skip to content

Better PWA color#4254

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
azlux:patch-1
Mar 4, 2022
Merged

Better PWA color#4254
Alkarex merged 1 commit intoFreshRSS:edgefrom
azlux:patch-1

Conversation

@azlux
Copy link
Copy Markdown
Contributor

@azlux azlux commented Mar 3, 2022

Hi,
Removing the color result to the browser choosing the good color depending of the system config.

Az

@azlux
Follow device colors
33c58a9 
Removing the color result to the browser choosing the good color depending of the system config.
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Mar 4, 2022

Hello,
Could you post of few screenshots before/after this change, to ease the review process?

@Alkarex Alkarex added this to the 1.20.0 milestone Mar 4, 2022
@Alkarex Alkarex requested a review from math-GH March 4, 2022 07:30
@azlux
Copy link
Copy Markdown
Contributor Author

azlux commented Mar 4, 2022

I upload two screenshot:
before
after

Check to top bar. My device is in dark theme, so by default, the system will choose a dark background.

Frenzie
Frenzie approved these changes Mar 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alkarex Alkarex merged commit da2adae into FreshRSS:edge Mar 4, 2022
@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented Mar 4, 2022 •
edited
Loading

Unfortunately it has no effect for my device (Android (dark theme) + Firefox 99.0 Nightly). Still the white top bar is shown (it makes the time and icons invisible).

(I re-installed the PWA)

@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented Mar 5, 2022

Unfortunately it has no effect for my device (Android (dark theme) + Firefox 99.0 Nightly). Still the white top bar is shown (it makes the time and icons invisible).

(I re-installed the PWA)

I think it is an issue of Firefox, not of FreshRSS. Other PWAs on my mobile device have the issue

@azlux azlux deleted the patch-1 branch March 5, 2022 19:05
@Frenzie Frenzie mentioned this pull request Mar 16, 2022
Closed
@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented Mar 29, 2022 •
edited
Loading

Current situation on Firefox (Nightly V100.0a1) on Android
This PR made something correct. The Icons on the Android top bar are now visible (yeah!):

grafik

To compare: The Twitter PWA does not have the correct settings: See white top bar
grafik

@math-GH math-GH mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

@math-GH math-GH Awaiting requested review from math-GH

Assignees

No one assigned

Labels

Theme 🖌

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@azlux @Alkarex @math-GH @Frenzie