Skip to content

Improve: manage feed in view within a slider#4226

Merged
Alkarex merged 12 commits intoFreshRSS:edgefrom
math-GH:improve-manage-feed-in-view-slider
Mar 22, 2022
Merged

Improve: manage feed in view within a slider#4226
Alkarex merged 12 commits intoFreshRSS:edgefrom
math-GH:improve-manage-feed-in-view-slider

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Feb 19, 2022

User Story:
As user I want to edit the feed name within the normal view (reader view has a bug #4224 ) without leaving the view because I found a little typo or want to config small things.

grafik

New:
the feed config opens in a side slider
grafik

grafik

Changes proposed in this pull request:

  • new: slider.js

How to test the feature manually:

  1. go to normal view
  2. manage/delete a feed

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the View label Feb 19, 2022
@math-GH math-GH added this to the 1.20.0 milestone Feb 19, 2022
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 19, 2022

Known issue:
when main.js is loaded after slider.js, than it does not work :/
grafik

It works, when slide.js is loaded after main.js
grafik

I have no idea why and how to solve it.

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Feb 21, 2022

(I have a very bad Internet connectivity for the next few days, but I should be operational again next week)

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Mar 22, 2022

Ping @Frenzie and @Alkarex

Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides the indentation thing

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Mar 22, 2022

lgtm besides the indentation thing

fixed

@Alkarex Alkarex merged commit 7d00ad8 into FreshRSS:edge Mar 22, 2022
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Mar 22, 2022

Sorry for the delay. I have tested a few cases (mobile, from the list of inactive feeds, etc.) and it is a nice improvement 👍🏻

@math-GH math-GH deleted the improve-manage-feed-in-view-slider branch March 23, 2022 11:31
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Mar 23, 2022

@math-GH The preview function of the full article retrieval is broken (opens in full window, and error with the content). I guess it might be related to this PR, but I have not yet investigated.
image

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Mar 23, 2022

I can confirm, that this PR broke this feature. Will investigate what/why happend

@math-GH math-GH mentioned this pull request Mar 26, 2022
2 tasks
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Oct 11, 2022 via email

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Oct 11, 2022

Sorry for the delay. I wanted to test a couple of things. I will try tonight or tomorrow.

I have no idea why this old comment got posted again. Probably a bug somewhere...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants