Improved: log page by math-GH · Pull Request #4204 · FreshRSS/FreshRSS

math-GH · 2022-02-06T15:25:26Z

Before:

The log was only available via the config dropdown menu.
Had no left navigation panel.
Pagination is not good usable in mobile view

After:

fresher layout
entry in the left navigation:
- admin user (has access to the system configuration): "Log" entry in "Administration" section
- non-admin user (has no access to the system configuration and no access to the system log messages): "Log" entry in "Configuration" section

Changes proposed in this pull request:

HTML and CSS

How to test the feature manually:

go to the logs page

Pull request checklist:

clear commit messages
code manually tested
RTL
after merging Improved: "Pagination" + load more button #4125 to edge: clean the CSS of pagination class

app/views/helpers/logs_pagination.phtml

Frenzie

Looks cool! No real comments.

app/views/helpers/logs_pagination.phtml

p/themes/Alternative-Dark/adark.css

Co-authored-by: Frans de Jonge <[email protected]>

Frenzie

lgtm!

p/themes/icons/warning.svg

…om/math-GH/FreshRSS into include-log-into-config-aside-menu

math-GH · 2022-02-22T20:30:18Z

Icons improved. Now they look more like the other icons

app/views/index/logs.phtml

…om/math-GH/FreshRSS into include-log-into-config-aside-menu

app/i18n/fr/conf.php

Co-authored-by: Alexandre Alapetite <[email protected]>

Alkarex · 2022-03-14T22:22:43Z

@math-GH Ups, I merged too fast. A couple of issues:

Notice: Undefined index: debug in /var/www/FreshRSS/app/Models/Themes.php on line 114

And missing horizontal scrollbar.

@Frenzie WebSub issue on your site? :-) Or is it a bug in my FreshRSS instance?

Frenzie · 2022-03-14T22:39:55Z

I'm not sure, aren't the hubs supposed to take care of that?

https://pubsubhubbub.appspot.com
https://pubsubhubbub.superfeedr.com
https://websubhub.com/hub

It's this plugin.
https://github.com/pubsubhubbub/wordpress-pubsubhubbub

Alkarex · 2022-03-22T10:27:47Z

SimplePie-related WebSub bug addressed in #4283

math-GH added 10 commits February 5, 2022 22:55

first draft

1bee130

wip

02d91f6

Theme Ansum

c1f5465

Update logs_pagination.phtml

871f5c8

Theme Mapco

73ff537

Update adark.css

26084d9

Update BlueLagoon.css

a93bb75

Update dark.css

b394dc0

Update screwdriver.css

030912a

Theme Swage

423b359

math-GH changed the title ~~Include log into config aside menu~~ Improved: log page Feb 6, 2022

math-GH added the UI 🎨 User Interfaces label Feb 6, 2022

math-GH added this to the 1.20.0 milestone Feb 6, 2022

Frenzie reviewed Feb 6, 2022

View reviewed changes

app/views/helpers/logs_pagination.phtml Outdated Show resolved Hide resolved

Frenzie reviewed Feb 6, 2022

View reviewed changes

app/views/helpers/logs_pagination.phtml Show resolved Hide resolved

Frenzie reviewed Feb 6, 2022

View reviewed changes

app/views/helpers/logs_pagination.phtml Outdated Show resolved Hide resolved

Frenzie approved these changes Feb 6, 2022

View reviewed changes

app/views/helpers/logs_pagination.phtml Outdated Show resolved Hide resolved

Frenzie reviewed Feb 6, 2022

View reviewed changes

p/themes/Alternative-Dark/adark.css Outdated Show resolved Hide resolved

math-GH and others added 12 commits February 6, 2022 21:26

Update app/views/helpers/logs_pagination.phtml

c5604bd

Co-authored-by: Frans de Jonge <[email protected]>

Update app/views/helpers/logs_pagination.phtml

8cb476f

Co-authored-by: Frans de Jonge <[email protected]>

Merge branch 'edge' into include-log-into-config-aside-menu

0664d00

Update template.css

8b27d8a

Update logs_pagination.phtml

129cc6f

Update logs_pagination.phtml

03789b9

Update logs_pagination.phtml

bd2d227

RTL CSS

927746d

Update dark.rtl.css

1928243

Update swage.css

3128d5f

fix CLI findings

8232f1b

Indentation fixed

39e2f8f

Merge branch 'edge' into include-log-into-config-aside-menu

b503f94

Frenzie approved these changes Feb 7, 2022

View reviewed changes

math-GH added 2 commits February 7, 2022 15:35

Merge branch 'edge' into include-log-into-config-aside-menu

99e7d74

Merge branch 'edge' into include-log-into-config-aside-menu

e6d4ea6

Alkarex reviewed Feb 13, 2022

View reviewed changes

p/themes/icons/warning.svg Outdated Show resolved Hide resolved

math-GH added 4 commits February 22, 2022 20:10

Merge branch 'edge' into include-log-into-config-aside-menu

ecd0ca8

icons improved

0eeb4b1

CSS: centered icons

6d52bb8

Merge branch 'include-log-into-config-aside-menu' of https://github.c…

1766368

…om/math-GH/FreshRSS into include-log-into-config-aside-menu

Alkarex reviewed Mar 5, 2022

View reviewed changes

app/views/index/logs.phtml Outdated Show resolved Hide resolved

math-GH added 6 commits March 10, 2022 20:41

i18n

66d8e69

Merge branch 'edge' into include-log-into-config-aside-menu

a49eac2

pipline test fixes

534b811

Merge branch 'include-log-into-config-aside-menu' of https://github.c…

52f0239

…om/math-GH/FreshRSS into include-log-into-config-aside-menu

Update conf.php

59c59f4

Update gen.php

3d249a7

Alkarex reviewed Mar 14, 2022

View reviewed changes

app/i18n/fr/conf.php Outdated Show resolved Hide resolved

math-GH and others added 2 commits March 14, 2022 20:16

Update app/i18n/fr/conf.php

c52bc2e

Co-authored-by: Alexandre Alapetite <[email protected]>

Merge branch 'edge' into include-log-into-config-aside-menu

37cbb81

Alkarex merged commit 6650d1d into FreshRSS:edge Mar 14, 2022

math-GH deleted the include-log-into-config-aside-menu branch March 14, 2022 22:13

math-GH mentioned this pull request Mar 15, 2022

[BUG] New Log layout #4272

Closed

This was referenced Jul 24, 2022

Cleanup CSS .pagination #4455

Merged

Fix: logs page=0 error #4460

Merged

math-GH mentioned this pull request Sep 10, 2022

Improved: Cleanup CSS of ".log" #4594

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improved: log page#4204

Improved: log page#4204
Alkarex merged 37 commits intoFreshRSS:edgefrom
math-GH:include-log-into-config-aside-menu

math-GH commented Feb 6, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frenzie left a comment

Uh oh!

Uh oh!

Uh oh!

Frenzie left a comment

Uh oh!

Uh oh!

math-GH commented Feb 22, 2022

Uh oh!

Uh oh!

Uh oh!

Alkarex commented Mar 14, 2022

Uh oh!

Frenzie commented Mar 14, 2022 •

edited

Loading

Uh oh!

Alkarex commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

math-GH commented Feb 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frenzie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Frenzie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

math-GH commented Feb 22, 2022

Uh oh!

Uh oh!

Uh oh!

Alkarex commented Mar 14, 2022

Uh oh!

Frenzie commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alkarex commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

math-GH commented Feb 6, 2022 •

edited

Loading

Frenzie commented Mar 14, 2022 •

edited

Loading