Skip to content

Improved: unread articles counter#4166

Merged
Alkarex merged 17 commits intoFreshRSS:edgefrom
math-GH:4068-unread-articles-count
Feb 4, 2022
Merged

Improved: unread articles counter#4166
Alkarex merged 17 commits intoFreshRSS:edgefrom
math-GH:4068-unread-articles-count

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Jan 20, 2022

Closes #4068 (Forum discussion)

Changes proposed in this pull request:

  • unread count of feeds is now aligned to the right hand side
    grafik

How to test the feature manually:

  1. see the unread numbers in normal/reading view

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH changed the title 4068 unread articles count Improved: unread articles counter Jan 20, 2022
@Alkarex Alkarex added the UI 🎨 User Interfaces label Jan 20, 2022
@Alkarex Alkarex added this to the 1.19.2 milestone Jan 20, 2022
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jan 21, 2022

@Alkarex Ist there any reason to release this PR with the next bugfix release 1.19.2?

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 21, 2022

No, and if not ready, it is not a problem at all

@math-GH math-GH marked this pull request as ready for review January 22, 2022 20:44
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jan 22, 2022

Ready for review. Feedback is welcome.
Please check your favorite themes (colors, contrast)

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 24, 2022

Let's release 1.19.2 in the coming days, and wait for 1.20 for this one after all

@Alkarex Alkarex modified the milestones: 1.19.2, 1.20.0 Jan 24, 2022
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Feb 4, 2022

Could you please check the conflicts @math-GH ?

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 4, 2022

Strange merge conflict. I am not 100% sure whether it is solved correctly or not.

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Feb 4, 2022

There was a remaining little problem with the new SASS syntax requiring variables.$sid-pills, see #4173

@Alkarex Alkarex merged commit dc27baa into FreshRSS:edge Feb 4, 2022
@math-GH math-GH deleted the 4068-unread-articles-count branch February 4, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants