Skip to content

Improved: Article header#4101

Merged
Alkarex merged 70 commits intoFreshRSS:edgefrom
math-GH:improve-article-header
Jul 17, 2022
Merged

Improved: Article header#4101
Alkarex merged 70 commits intoFreshRSS:edgefrom
math-GH:improve-article-header

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Dec 30, 2021

Closes #1867 + some more improvements

First draft

(final PR see comments below)

Before:
grafik

After:
grafik

in action;
open-collapse-new-header

Changes proposed in this pull request:

  1. if the article is open, then the source website, title and date is hidden.
  2. Source website is now above the title. Tag list is added (as wished in [Feature Request] Make feed tags visible by default #1867).
  3. close button, that collapse the article

Not visible:
HTML5 tag article used

How to test the feature manually:

  1. open/close articles in normal view

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Dec 30, 2021

Draft PR to collect your feedback

@math-GH math-GH added this to the 1.20.0 milestone Dec 30, 2021
@math-GH math-GH added the UI 🎨 User Interfaces label Dec 30, 2021
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Dec 30, 2021

Personally, I like the tags, but I am not so found of the vanishing top line (title, etc.). I can can better like the first line unchanged when opening / closing.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Dec 31, 2021

I concur. Additionally, it hides the closing touch target.

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Dec 31, 2021

Additionally, it hides the closing touch target.

Which closing touch target do you mean? The "header" row is unchanged clickable to collapse the article. Now, the close icon gives a visible hint, how to close the article

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Dec 31, 2021

The "header" row is unchanged clickable to collapse the article.

That's the definition of hidden. ;-)

Now, the close icon gives a visible hint, how to close the article

Fwiw I use that all the time to open the link. If we want a closing X I think I'd rather have it with the actual content.

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jan 17, 2022

The final result looks like this:

grafik

@math-GH math-GH marked this pull request as ready for review January 17, 2022 21:52
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 6, 2022

Anything left todo?
Final result see previous comment

@math-GH math-GH marked this pull request as draft July 6, 2022 16:42
@math-GH math-GH marked this pull request as ready for review July 7, 2022 19:39
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jul 7, 2022

@Alkarex: I fixed all your points

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jul 11, 2022

@math-GH I have fixed a JavaScript error:

image

Please double-check. (Potential side-effect on ?c=configure&a=system, which uses some of the same logic)

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jul 12, 2022

P.S. Is it on purpose that a link icon has been added next to the article title?
image

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jul 13, 2022

P.S. Is it on purpose that a link icon has been added next to the article title? image

It is on purpose. The headline is a link to the external article.
I am not sure if it is a good idea.

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jul 14, 2022

It is on purpose. The headline is a link to the external article. I am not sure if it is a good idea.

I am not so found of it personally. There is already a clear link, and I think it clutters a bit the interface.

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jul 15, 2022

Improved

@Alkarex Alkarex merged commit b2e46d6 into FreshRSS:edge Jul 17, 2022
@math-GH math-GH deleted the improve-article-header branch July 18, 2022 11:39
@Alwaysin
Copy link
Copy Markdown
Contributor

Alwaysin commented Jul 23, 2022

On Nord theme, this PR changes the color of the title from:
chrome_2022-07-23_14-32-20

to:
chrome_2022-07-23_14-34-21

Is this desirable? I find it very hard to read it.

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jul 23, 2022

On Nord theme, this PR changes the color of the title [ ...]
Is this desirable? I find it very hard to read it.

Thanks. I fixed it with #4459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Make feed tags visible by default

4 participants