Skip to content

4051 read fav hooks#4052

Closed
jonasborn wants to merge 8 commits intoFreshRSS:edgefrom
jonasborn:4051-read-fav-hooks
Closed

4051 read fav hooks#4052
jonasborn wants to merge 8 commits intoFreshRSS:edgefrom
jonasborn:4051-read-fav-hooks

Conversation

@jonasborn
Copy link
Copy Markdown

@jonasborn jonasborn commented Dec 10, 2021 •
edited
Loading

Closes #4051

Changes proposed in this pull request:

  • Added hook calls to entryController, look for entry_read, entry_read_multiple and entry_favorite

How to test the feature manually:

  1. Create a extension and register hooks for entry_read, entry_read_multiple and entry_favorite

Pull request checklist:

  • [+] clear commit messages
  • [+] code manually tested
  • [-] unit tests written (optional if too hard)
  • [+] documentation updated

Additional information can be found in the documentation.

Frenzie
Frenzie reviewed Dec 10, 2021
View reviewed changes
@Alkarex Alkarex added this to the 1.20.0 milestone Dec 10, 2021
@jonasborn jonasborn requested a review from Frenzie December 11, 2021 02:03
@jonasborn

This comment has been minimized.

Sign in to view
@jonasborn
Copy link
Copy Markdown
Author

jonasborn commented Dec 13, 2021

image
app/Controllers/entryController.php:73
image
\FreshRSS_EntryDAOSQLite::markReadEntries
@Alkarex
Seems like the call is setting $onlyFavorites with $is_read - is there a reason for this?

@jonasborn jonasborn marked this pull request as draft December 13, 2021 11:02
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Dec 28, 2021

Seems like the call is setting $onlyFavorites with $is_read - is there a reason for this?

@jonasborn Sorry for the delay. Well spotted; this indeed looks like a bug (that code is rarely called, luckily). PR welcome.

@jonasborn jonasborn closed this Apr 1, 2022
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jul 22, 2022
@Alkarex
Fix rare read call bug
7079b92 
FreshRSS#4052 (comment)
Bug from FreshRSS#1995
@Alkarex Alkarex mentioned this pull request Jul 22, 2022
Merged
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jul 22, 2022

Seems like the call is setting $onlyFavorites with $is_read - is there a reason for this?

@jonasborn Sorry for the delay. Well spotted; this indeed looks like a bug (that code is rarely called, luckily). PR welcome.

Fixed in #4456

Alkarex added a commit that referenced this pull request Jul 28, 2022
@Alkarex
Fix rare read call bug (#4456)
18b8e91 
#4052 (comment)
Bug from #1995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Awaiting requested review from Frenzie

Assignees

No one assigned

Labels

Extension 🔌

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

Add support for read and bookmark

3 participants

@jonasborn @Alkarex @Frenzie