Skip to content

Improve: new article banner#4037

Merged
Alkarex merged 5 commits intoFreshRSS:edgefrom
math-GH:improve-new-article-banner
Feb 5, 2022
Merged

Improve: new article banner#4037
Alkarex merged 5 commits intoFreshRSS:edgefrom
math-GH:improve-new-article-banner

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Dec 7, 2021

grafik

Changes proposed in this pull request:

  • in theme "Origine" fixed: the blue box had a padding, so that not the whole box was clickable
  • all themes: background change while hovering now assigned to the link, not to the box

How to test the feature manually:

  1. hover with the mouse over the new article banner

Pull request checklist:

  • [x ] clear commit messages
  • [ x] code manually tested

@Alkarex Alkarex added the UI 🎨 User Interfaces label Dec 7, 2021
@Alkarex Alkarex added this to the 1.20.0 milestone Dec 7, 2021
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Dec 8, 2021

@Alkarex maybe it is worth for 1.19, because with this #3999 I see this blue banner much more often* than in 1.18 and I am annoyed often about the small click area.

*) I use the edge branch on my daily system to test it and enjoy the new functions

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 5, 2022

@Alkarex @Frenzie Ready for 1.20 :)

Frenzie
Frenzie approved these changes Feb 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also looks good in mobile view?

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 5, 2022

lgtm, also looks good in mobile view?

Nothing visible changed. Just the :hover and the clickable area.

@Alkarex Alkarex merged commit 4d5f3a2 into FreshRSS:edge Feb 5, 2022
@math-GH math-GH deleted the improve-new-article-banner branch February 5, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

UI 🎨 User Interfaces

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@math-GH @Frenzie @Alkarex