Skip to content

Improve showing notification banner#4023

Merged
Alkarex merged 21 commits intoFreshRSS:edgefrom
math-GH:improve-showing-notification-banner
Feb 4, 2022
Merged

Improve showing notification banner#4023
Alkarex merged 21 commits intoFreshRSS:edgefrom
math-GH:improve-showing-notification-banner

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Dec 4, 2021

Part 1:

While I reproduced #3686 I saw that the time to read the notification is to short (4 seconds).

Changes proposed in this pull request:

  • if it is a 'bad' (=red) notification, than the time is doubled to disappear (= 8 seconds)
  • if the user moves the mouse pointer over the notification, the timer stopps
  • if the user's mouse pointer leaves the notification it will disappear after 1 second
  • changed the onlick-event of the close icon to addEventListener

How to test the feature manually:
grafik

  1. go to subscription management: page 'add a feed or category'
  2. press the 'add' button of 'add a category' (leave the input empty!)
  3. a read notification will appear
  4. test the changes

Part 2

Before:
The text inside of the notification could be hidden behind the close button and the grey button could be invisible over the text. And the line-height is strange.
grafik

After:
No text anymore behind the close button.
grafik

While hovering the grey icon will become white
grafik

I checked all themes and improved it in some little cases (f.e. readable links)

Pull request checklist:

  • clear commit messages
  • code manually tested

@Alkarex Alkarex added this to the 1.20.0 milestone Dec 4, 2021
@Alkarex Alkarex added the UI 🎨 User Interfaces label Dec 4, 2021
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Dec 4, 2021

shit. this changes should become another PR and not within this PR :/
OK, it can stay here. It is also connected with the notification banners. Will extend the PR text with this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants