Skip to content

Fix JS error: #new-article missed#3999

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
math-GH:fix-js-error-new-article
Nov 30, 2021
Merged

Fix JS error: #new-article missed#3999
Alkarex merged 1 commit intoFreshRSS:edgefrom
math-GH:fix-js-error-new-article

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Nov 27, 2021

Before:
grafik

This <div id="new-article"> is missed, when no article is in the list and only the alert is shown.
This blue alert is shown, when articles are listed
grafik

Changes proposed in this pull request:

  • added the missed <div> into the section with the alert

How to test the feature manually:

  1. go to normal view or reader view
  2. all articles are read
  3. wait till new articles in background are fetched (maybe a cron job is needed)
  4. see the blue alert

Pull request checklist:

  • clear commit messages
  • code manually tested

@Alkarex Alkarex added this to the 1.19.0 milestone Nov 27, 2021
@Alkarex Alkarex merged commit c5d444e into FreshRSS:edge Nov 30, 2021
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Nov 30, 2021

Thanks! I had to check a few related cases such as with global view, but all good 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants