Skip to content

Improve subscription list drag and drop#3953

Merged
Alkarex merged 23 commits intoFreshRSS:edgefrom
math-GH:improve-subscription-list-drag-and-drop
Feb 5, 2022
Merged

Improve subscription list drag and drop#3953
Alkarex merged 23 commits intoFreshRSS:edgefrom
math-GH:improve-subscription-list-drag-and-drop

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Nov 1, 2021

Closes #3892

After:
grafik

  1. Dragging object marked yellow (cog icon will be hidden)
  2. (dragging object)
  3. drop zones are marked with yellow stripped background
  4. drag-hover marked with yellow plain background
  5. dropped items are listed at the top of the list (because they needed to ordered alphabetical. Will be done after reload the page)

grafik
The drag&drop function is now better visible with a changed mouse cursor (now: move, before: grab)

This PR closes #3892 because you cannot drop a feed within the category where it comes from. So it will not create a 404 error. Technical solution: no dropzone for a <ul> where the object comes from.

How to test the feature manually:

  1. go to subscription manage page
  2. drag and drop the feeds around

Pull request checklist:

  • clear commit messages
  • code manually tested
  • phpcs
  • CSS RTL

@Alkarex Alkarex added the UI 🎨 User Interfaces label Nov 2, 2021
@Alkarex Alkarex added this to the 1.20.0 milestone Nov 2, 2021
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 5, 2022

Ready for 1.20 :)

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Feb 5, 2022

Minor detail: it looks like feeds remain in italics after a drag & drop. By design?
image

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Feb 5, 2022

Minor detail: it looks like feeds remain in italics after a drag & drop. By design? image

yes, it is by design. After dropping the new item is placed at the top and in italics style.
After reload it will be ordered alphabetically

@Alkarex Alkarex merged commit 9224668 into FreshRSS:edge Feb 5, 2022
@math-GH math-GH deleted the improve-subscription-list-drag-and-drop branch February 5, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Subscription Management: reordering feeds

3 participants