Skip to content

fix broken sharing services (part 2): delete Blogotext#3812

Closed
math-GH wants to merge 3 commits intoFreshRSS:edgefrom
math-GH:delete-blogotext
Closed

fix broken sharing services (part 2): delete Blogotext#3812
math-GH wants to merge 3 commits intoFreshRSS:edgefrom
math-GH:delete-blogotext

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Aug 30, 2021

Closes a part of #3793

sub PR of #3794 as @Alkarex suggested

Changes proposed in this pull request:

  • remove: the blogotext sharing option

How to test the feature manually:
check the sharing options

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH mentioned this pull request Aug 30, 2021
2 tasks
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Sep 3, 2021

What is the plan with this PR?
Set it on hold?
Merge it and wait if blogotext is still needed?

'blogotext' => array(
'url' => '~URL~/admin/links.php?url=~LINK~',
'transform' => array(),
'help' => 'http://lehollandaisvolant.net/blogotext/fr/',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about blogotext, but I will make the semantic point that unmaintained for a little while isn't the same thing as broken. This help link is broken though; presumably that should be something like https://github.com/BlogoText/blogotext instead.

So I'm on the side of keep. It's not like something with fixes for PHP 7.3/8.0 is something hugely outdated that'll only run on 5+ year old systems, even if it might end up there a few years down the line.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to refuse this PR.

feel free to fix the link.

As I feel free to delete old stuff that does not make sense to maintain. Blogotext creates 2 PR where blogotext code had to change (1 PR that reordered the array, 1 PR that will fix the link). I do not like technical debts.

If we do not want to delete it I would suggest to mark blogotext as deprecated with the hint that users of FreshRSS and blogotext should sent a message to this issue to mark it as "still in use".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the issues is that we have, by design, no telemetry for which features are used, and very little feedback from our user-base, so I tend to be conservative and wait a bit more before deleting things. I can see some user activity from April this year on https://github.com/BlogoText/blogotext/issues
Having a deprecated indication could be interesting.

@math-GH math-GH marked this pull request as draft September 13, 2021 20:34
@math-GH math-GH added this to the 1.22.0 milestone Mar 22, 2022
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Mar 22, 2022

Blogotext as sharing service in FreshRSS will be marked as deprecated in 1.20.0 and is planned to be removed in 1.22.0 (see #4269)

@math-GH math-GH added the deprecated Features marked as deprecated or deprecated marked features will be removed label May 23, 2023
@Alkarex Alkarex modified the milestones: 1.22.0, 1.23.0 Jul 30, 2023
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Sep 22, 2023

@Alkarex Is there any reason for postponing this PR from 1.22 to 1.23?

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Sep 23, 2023

@Alkarex Is there any reason for postponing this PR from 1.22 to 1.23?

@math-GH It was mostly to wait a bit more, with the same reasoning as #3812 (comment) . I would rather merge at the start of a new development phase, to get some time to hear whether anyone complains

@Alkarex Alkarex modified the milestones: 1.23.0, 1.24.0 Nov 24, 2023
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Mar 5, 2024

@Alkarex Is there any reason for postponing this PR from 1.22 to 1.23?

@math-GH It was mostly to wait a bit more, with the same reasoning as #3812 (comment) . I would rather merge at the start of a new development phase, to get some time to hear whether anyone complains

Is now a good time?

Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're now a few years down the line.

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Mar 6, 2024

Sorry I forgot about it. Could be merge right after the release of 1.24?

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Mar 21, 2024

see #6225

@math-GH math-GH closed this Mar 21, 2024
@math-GH math-GH deleted the delete-blogotext branch March 21, 2024 21:13
@Alkarex Alkarex modified the milestones: 1.25.0, 1.24.2 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecated Features marked as deprecated or deprecated marked features will be removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants