Merged
Conversation
The new hook allows to add maintenance extensions at the user level. See FreshRSS#3398
Alkarex
reviewed
Feb 11, 2021
|
|
||
| FreshRSS_Auth::giveAccess(); | ||
|
|
||
| Minz_ExtensionManager::callHook('freshrss_user_maintenance'); |
Member
There was a problem hiding this comment.
Would be good to put it in the CLI version as well https://github.com/FreshRSS/FreshRSS/blob/master/cli/actualize-user.php
Member
Author
There was a problem hiding this comment.
I've tried but it seems that it is not triggered. :/
Member
Author
There was a problem hiding this comment.
I've tried without success
Member
There was a problem hiding this comment.
Have you tested with a system or user extension?
Member
Author
There was a problem hiding this comment.
I tried with a system extension
Member
Author
There was a problem hiding this comment.
So far, no success either :/
Member
There was a problem hiding this comment.
Let's merge here and come back to it when #3443 works
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Feb 11, 2021
Merged
Alkarex
added a commit
that referenced
this pull request
Feb 26, 2021
* Extensions in CLI #3440 (comment) * Also user extensions
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Mar 30, 2023
Follow-up of FreshRSS#3440 The hook was called before registering all the extensions for the current user
Alkarex
added a commit
that referenced
this pull request
Apr 4, 2023
* Fix extension freshrss_user_maintenance in actualize_script Follow-up of #3440 The hook was called before registering all the extensions for the current user * PHPStan Level 6 for extensions And remove 5-year old legacy format of enabled extensions < FreshRSS 1.11.1 * Fix multiple bugs in extensions * Minor typing * Don't change signature of methods supposed to be overridden * PHPStan Level 9 and compatibility Intelliphense * Set as final the methods not supposed to be overriden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3398 (partially)
Changes proposed in this pull request:
How to test the feature manually:
make refreshcommand.Pull request checklist:
Additional information can be found in the documentation.
The new hook allows to add maintenance extensions at the user level.