Possiblity to autoinstall in Docker Compose#3353
Merged
Alkarex merged 3 commits intoFreshRSS:masterfrom Jan 11, 2021
Merged
Conversation
#fix FreshRSS#3349 It is simply calling our existing CLI: do-install.php and create-user.php https://github.com/FreshRSS/FreshRSS/tree/master/cli FreshRSS will typically be ready a few seconds before the database, so introduce a tolerance when the database is not available / up (yet) by trying a few times to connect. Also useful to avoid service interruption when DB service is restarted. Example: ```yml freshrss-app: image: freshrss/freshrss container_name: freshrss-app hostname: freshrss-app restart: unless-stopped ports: - "8080:80" depends_on: - freshrss-db volumes: - data:/var/www/FreshRSS/data - extensions:/var/www/FreshRSS/extensions environment: CRON_MIN: '*/20' FRESHRSS_ENV: development FRESHRSS_INSTALL: |- --api_enabled --base_url https://rss.example.net --db-base freshrss --db-host freshrss-db --db-password freshrss --db-type pgsql --db-user freshrss --default_user admin --language en FRESHRSS_USER: |- --api_password freshrss --email [email protected] --language en --password freshrss --user admin TZ: Europe/Paris ```
Frenzie
reviewed
Jan 9, 2021
Member
Frenzie
left a comment
There was a problem hiding this comment.
While it should be harmless here, it's probably better to avoid the shellcheck warning you're channeling with useless cat & probably also quotation marks around the $() subshell. (And also double check if it has something else to say besides what stands out to me at a glance.)
Member
Author
|
I think I will look again at |
Member
Author
|
@Frenzie Please give an example, I am not sure what you mean precisely :-) |
Frenzie
reviewed
Jan 9, 2021
Frenzie
reviewed
Jan 9, 2021
Frenzie
reviewed
Jan 9, 2021
0f5b318 to
f5024c5
Compare
Frenzie
approved these changes
Jan 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fix #3349
It is simply calling our existing CLI: do-install.php and create-user.php
https://github.com/FreshRSS/FreshRSS/tree/master/cli
(So all the API options are available)
FreshRSS will typically be ready a few seconds before the database, so introduce a tolerance when the database is not available / up (yet) by trying a few times to connect. Also useful to avoid service interruption when DB service is restarted.
Example: