tec: Add a make lint command in the Makefile#2996
Merged
Alkarex merged 1 commit intoFreshRSS:masterfrom May 25, 2020
Merged
Conversation
Frenzie
approved these changes
May 22, 2020
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
Looks good enough to me for basic use.
| $(PHP) ./bin/phpunit --bootstrap ./tests/bootstrap.php ./tests | ||
|
|
||
| .PHONY: lint | ||
| lint: bin/phpcs ## Run the linter on the PHP files |
Member
There was a problem hiding this comment.
Maybe lint should be a broader target with this one being something like lint-php?
Alkarex
approved these changes
May 24, 2020
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
May 25, 2020
By analogy with <FreshRSS#2996>.
4 tasks
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
May 25, 2020
By analogy with <FreshRSS#2996>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2722 (I almost forget about this ticket :))
Note: this PR is not urgent so it can wait for the 1.16.1 to be released.
Changes proposed in this pull request:
php7-xmlwriterandphp7-tokenizerto the Alpine image (required by PHP_CodeSniffer)make lintandmake lint-fixcommands to the MakefileHow to test the feature manually:
Execute
make lintandmake lint-fixin a console, and verifies it downloads the binaries and executes the linter.Pull request checklist:
Additional information can be found in the documentation.