Skip to content

[UI] Add RTL support with RTLCSS#2776

Merged
Frenzie merged 13 commits intoFreshRSS:masterfrom
Frenzie:cssjanus-take3
Mar 1, 2020
Merged

[UI] Add RTL support with RTLCSS#2776
Frenzie merged 13 commits intoFreshRSS:masterfrom
Frenzie:cssjanus-take3

Conversation

@Frenzie
Copy link
Copy Markdown
Member

@Frenzie Frenzie commented Jan 18, 2020

Closes #673. See #2678 for an alternative approach that's harder to realize within the current confines of the program.

Changes proposed in this pull request:

  • Add RTL CSS files.
  • Add make rtl command to manually update RTL CSS files. This requires the presence of the rtlcss command line app, which can be installed using npm install -g rtlcss.

How to test the feature manually:

  1. Select Hebrew as your language.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

This change is Reviewable

@Frenzie Frenzie marked this pull request as ready for review February 22, 2020 15:07
@Frenzie Frenzie added I18n 🌍 Translations UI 🎨 User Interfaces labels Feb 22, 2020
@Alkarex Alkarex added this to the 1.16.0 milestone Feb 29, 2020
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Feb 29, 2020

Good for me 👍

@Frenzie Frenzie merged commit 25666ec into FreshRSS:master Mar 1, 2020
@Frenzie Frenzie deleted the cssjanus-take3 branch March 1, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I18n 🌍 Translations UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTL support

2 participants