Merged
Conversation
After moving to PHP 5.6+ FreshRSS#2527 it should not be necessary to have the JSON.php fallback anymore, which was mainly there due to an obscure licensing issue 6 years ago in Debian https://wiki.debian.org/qa.debian.org/jsonevil , which broke Ubuntu 13.10 FreshRSS#306
Member
Author
|
(N.B. merge #2527 first) |
Frenzie
approved these changes
Sep 17, 2019
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
This one definitely raised my eyebrows the first time I noticed it.
marienfressinaud
approved these changes
Sep 18, 2019
Member
marienfressinaud
left a comment
marienfressinaud
left a comment
There was a problem hiding this comment.
ah, great! Less code <3
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After moving to PHP 5.6+ #2527
it should not be necessary to have the JSON.php fallback anymore,
which was mainly there due to an obscure licensing issue 6 years ago in Debian
https://wiki.debian.org/qa.debian.org/jsonevil ,
which broke Ubuntu 13.10 #306