Skip to content

Require PHP 5.6+#2527

Merged
Alkarex merged 2 commits intoFreshRSS:devfrom
Alkarex:php5.6
Sep 18, 2019
Merged

Require PHP 5.6+#2527
Alkarex merged 2 commits intoFreshRSS:devfrom
Alkarex:php5.6

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented Sep 17, 2019

@Alkarex Alkarex added this to the 1.15.0 milestone Sep 17, 2019
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Sep 17, 2019
After moving to PHP 5.6+ FreshRSS#2527
it should not be necessary to have the JSON.php fallback anymore, which
was mainly there due to an obscure licensing issue 6 years ago in Debian
https://wiki.debian.org/qa.debian.org/jsonevil , which broke Ubuntu
13.10 FreshRSS#306
Copy link
Copy Markdown
Member

@marienfressinaud marienfressinaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Alkarex Alkarex merged commit a8bbcef into FreshRSS:dev Sep 18, 2019
@Alkarex Alkarex deleted the php5.6 branch September 18, 2019 14:41
Alkarex added a commit that referenced this pull request Sep 18, 2019
After moving to PHP 5.6+ #2527
it should not be necessary to have the JSON.php fallback anymore, which
was mainly there due to an obscure licensing issue 6 years ago in Debian
https://wiki.debian.org/qa.debian.org/jsonevil , which broke Ubuntu
13.10 #306
Alkarex added a commit that referenced this pull request Sep 29, 2019
* PDO refactor

* Automatic prefix when using the syntax `_tableName`
* Uniformity: MySQL is now PDO::ATTR_EMULATE_PREPARES = false just like SQLite and PostgreSQL, with consequences such as only one statement per query
* Use PDO methods exec(), query(), prepare() + execute() in a more efficient way
* Remove auto-update SQL code for versions older than FreshRSS 1.5 (3 years old)
* The name of the default category is set in PHP instead of in the DB (simplies SQL and allows changing the name according to the FreshRSS language)
* Rename `->bd` to `->pdo` (less of a frenshism, and more informative)
* Fix some requests, which were not compatible with MySQL prepared statements

* Whitespace

* Fix syntax for PostgreSQL sequences

+ MySQL install

* Minor formatting

* Fix lastInsertId for PostgreSQL

* Use PHP 5.6+ const

Take advantage of #2527
https://www.php.net/manual/en/migration56.new-features.php

* A bit of forgotten PHP 5.6 simplification for cURL

* Forgotten $s

* Mini fix custom user config

https://github.com/FreshRSS/FreshRSS/pull/2490/files#r326290346

* More work on install.php but not finished

* install.php working

* More cleaning of PDO in install

* Even more simplification

Take advantage of PDO->exec() to run multiple statements

* Disallow changing the name of the default category

#2522 (comment)
@Alkarex Alkarex mentioned this pull request Oct 26, 2019
@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented Feb 29, 2020

SimplePie now also requires PHP 5.6+ simplepie/simplepie#625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants