Require PHP 5.5+ by Alkarex · Pull Request #2495 · FreshRSS/FreshRSS

Alkarex · 2019-08-17T19:16:18Z

#2469 (comment)
I think it would be reasonable to require PHP 5.5+ for the core of FreshRSS after all.

As Frenzie said, WordPress currently requires PHP 5.6.20+, and it is the most popular PHP application.

We would loose about 20% of the PHP servers according to https://w3techs.com/technologies/details/pl-php/5/all but I expect this number to drop fast after the release of CentOS 8 (CentOS accounts for 17% of Linux servers https://w3techs.com/technologies/details/os-linux/all/all ).

Distributions:

no impact on Ubuntu, Fedora, Alpine, OpenWRT, FreeBSD, OpenSuze, Mageia, as all active versions have PHP ≥ 7
no impact on Synology, as all active versions have PHP ≥ 5.6
we drop Debian 8 Jessie (-2020) - we keep supporting Debian 9 Stretch (2017-06) - current is Debian 10 Buster
we drop Red Hat 7 (-2024) - we keep supporting RHEL 8 (2019-05)
we drop CentOS 7 (-2024) - we will support CentOS 8 (to be released soonish)

When dropping older versions, I can better like when it is for a good reason, and there is actually one with PHP 5.5, namely generators (yield) https://php.net/language.generators.overview which I consider
using.

FreshRSS#2469 (comment) I think it would be reasonable to require PHP 5.5+ for the core of FreshRSS after all. As Frenzie said, WordPress currently requires PHP 5.6.20+, and it is the most popular PHP application. We would loose about 20% of the PHP servers according to https://w3techs.com/technologies/details/pl-php/5/all but I expect this number to drop fast after the release of CentOS 8 (CentOS accounts for 17% of Linux servers https://w3techs.com/technologies/details/os-linux/all/all ). Distributions: * no impact on Ubuntu, Fedora, Alpine, OpenWRT, FreeBSD, OpenSuze, Mageia, as all active versions have PHP > 7 * no impact on OpenSuze, Synology, as all active versions have PHP > 5.5 * we drop Debian 8 Jessie (-2020) - we keep supporting Debian 9 Stretch (2017-06) - current is Debian 10 Buster * we drop Red Hat 7 (-2024) - we keep supporting RHEL 8 (2019-05) * we drop CentOS 7 (-2024) - we will support CentOS 8 (to be released soonish) When dropping older versions, I can better like when it is for a good reason, and there is actually one with PHP 5.5, namely generators (yield) https://php.net/language.generators.overview which I consider using.

Alkarex · 2019-08-17T19:23:36Z

Previous discussions:

lib/lib_rss.php

.travis.yml

Co-Authored-By: Frans de Jonge <[email protected]>

README.fr.md

Require PHP 5.5+ FreshRSS#2495

Alkarex · 2019-08-19T11:58:28Z

Actually, moving to PHP 5.6+ would not be much harder than 5.5+ based on the statistics and versions available in the distributions (which have either a version <= 5.4 or >= 5.6).
I could not find any big distribution on DistroWatch that is maintaining a PHP 5.5, e.g. https://distrowatch.com/table.php?distribution=Debian

Frenzie · 2019-08-19T12:57:21Z

No real objections here. Anything specific though?

https://www.php.net/manual/en/migration56.new-features.php

A few of those sound somewhat interesting (e.g., variadic functions) but at the same time a minor syntactic convenience isn't much of a reason.

Alkarex · 2019-08-19T19:24:03Z

Ok. So let's stick to 5.5 now with a note that if we need 5.6 for anything, we can update without delay.

marienfressinaud · 2019-08-20T08:54:16Z

I'm ok with this decision too 👍

I don't know how relevant the stats from w3techs.com are for our users, it may be interesting to do a survey to ask users where and how they host their instance of FreshRSS. Or even to add an option in FRSS (disabled by default) to send anonymous information automatically (but it's more work and I don't have time to work on this for the moment)

lib/Minz/Configuration.php

FreshRSS#2495 (comment) https://php.net/ref.opcache We need to retest the performances FreshRSS#2205

#2495 (comment) https://php.net/ref.opcache We need to retest the performances #2205

Require PHP 5.5+ FreshRSS#2495

* CLI to export/import any database to/from SQLite Require PHP 5.5+ #2495 * Travis * Execution rights * Fix wrong static fields * Fix MySQL bad default buffering https://stackoverflow.com/questions/6895098/pdo-mysql-memory-consumption-with-large-result-set/6935271#6935271 https://php.net/manual/ref.pdo-mysql * Fix count on progression * Avoid static DB information To ease working with two DBs at the same time * Less static, simplify Needs some testing * Small corrections * Special case for SQLite to SQLite * Modify special case for SQLite * Remove special case for SQLite More uniform logic for the 3 databases. Fix wrong DROP TABLE for SQLite. * Drop indexes * Revert "Drop indexes" This reverts commit f28d2ba. * Fix deletion * Fix classic export * Update cli/README.md Co-Authored-By: Marien Fressinaud <[email protected]> * Addressing part of review * Remove goto 😢 * Travis * Comment for SQLite case * Fix missing fields when inserting

Alkarex · 2019-09-16T18:58:18Z

Actually, I am refactoring a bit our PDO code (#2522 ) and I do have a wish to move to PHP 5.6+ to be able to use constant arrays
https://www.php.net/manual/en/migration56.new-features.php

Instead of the current global approach, which is not so nice, e.g.:

FreshRSS/app/Models/UserDAO.php

Lines 21 to 22 in 8dcdde6

    
           global $SQL_CREATE_TABLES, $SQL_CREATE_TABLE_ENTRYTMP, $SQL_CREATE_TABLE_TAGS; 
        
           if (is_array($SQL_CREATE_TABLES)) {

FreshRSS/app/SQL/install.sql.pgsql.php

Lines 4 to 9 in c76a318

    
           global $SQL_CREATE_TABLES; 
        
           $SQL_CREATE_TABLES = array( 
        
           'CREATE TABLE IF NOT EXISTS "%1$scategory" ( 
        
           	"id" SERIAL PRIMARY KEY, 
        
           	"name" VARCHAR(255) UNIQUE NOT NULL 
        
           );',

What do you think? Is it worth it?

Frenzie · 2019-09-16T19:10:40Z

It's a real feature, so I don't see why not. 👍

marienfressinaud · 2019-09-17T07:44:02Z

It would be a nice simplification :) and #2495 (comment) was already a sufficient reason to move on

Alkarex · 2019-09-17T08:11:29Z

CentOS 8 will be released next week with PHP 7.2 https://wiki.centos.org/About/Building_8

Discussion FreshRSS#2495 (comment) Needed for constant arrays https://www.php.net/manual/en/migration56.new-features.php which will be used in FreshRSS#2522

Needed for `CREATE INDEX IF NOT EXISTS` syntax. Supported as back as Ubuntu 16.04 LTS. Similar version checks than for the PHP version bump FreshRSS#2495 https://www.postgresql.org/docs/9.5/sql-createindex.html https://www.postgresql.org/docs/9.5/release-9-5.html

Needed for `CREATE INDEX IF NOT EXISTS` syntax. Supported as back as Ubuntu 16.04 LTS. Similar version checks than for the PHP version bump #2495 https://www.postgresql.org/docs/9.5/sql-createindex.html https://www.postgresql.org/docs/9.5/release-9-5.html

https://php.net/migration54.new-features thanks to FreshRSS#2495 Use `<?= ?>` instead of `<?php echo; ?>` 10kB of code saved :-) Done with regular expression: ``` <\?php echo (.+?);? *\?> <?= \1 ?> ```

* Take advantage of PHP 5.4+ short echo https://php.net/migration54.new-features thanks to #2495 Use `<?= ?>` instead of `<?php echo; ?>` 10kB of code saved :-) Done with regular expression: ``` <\?php echo (.+?);? *\?> <?= \1 ?> ``` * Try Travis fix squizlabs/PHP_CodeSniffer#2045 (comment)

Alkarex added this to the 1.15.0 milestone Aug 17, 2019

Version note for JSON.php

a394544

Alkarex commented Aug 17, 2019

View reviewed changes

lib/lib_rss.php Show resolved Hide resolved

hex2bin

3d7f92a

Frenzie reviewed Aug 18, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Update .travis.yml

4b0c8f9

Co-Authored-By: Frans de Jonge <[email protected]>

Frenzie reviewed Aug 18, 2019

View reviewed changes

README.fr.md Show resolved Hide resolved

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Aug 18, 2019

CLI to export/import any database to/from SQLite

a7bd8ae

Require PHP 5.5+ FreshRSS#2495

Alkarex mentioned this pull request Aug 18, 2019

CLI to export/import any database to/from SQLite #2496

Merged

marienfressinaud approved these changes Aug 20, 2019

View reviewed changes

lib/Minz/Configuration.php Show resolved Hide resolved

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Aug 20, 2019

Docker Alpine opcache

4ef1182

FreshRSS#2495 (comment) https://php.net/ref.opcache We need to retest the performances FreshRSS#2205

Alkarex mentioned this pull request Aug 20, 2019

Docker Alpine opcache #2498

Merged

Alkarex merged commit fd33d92 into FreshRSS:dev Aug 20, 2019

Alkarex deleted the require_php5.5 branch August 20, 2019 12:55

Alkarex added a commit that referenced this pull request Aug 20, 2019

Docker Alpine opcache (#2498)

d09826c

#2495 (comment) https://php.net/ref.opcache We need to retest the performances #2205

marienfressinaud pushed a commit to flusio/FreshRSS that referenced this pull request Sep 13, 2019

CLI to export/import any database to/from SQLite

f8a37b8

Require PHP 5.5+ FreshRSS#2495

marienfressinaud pushed a commit to flusio/FreshRSS that referenced this pull request Sep 15, 2019

CLI to export/import any database to/from SQLite

2c49483

Require PHP 5.5+ FreshRSS#2495

marienfressinaud pushed a commit to flusio/FreshRSS that referenced this pull request Sep 15, 2019

CLI to export/import any database to/from SQLite

e95a055

Require PHP 5.5+ FreshRSS#2495

Alkarex mentioned this pull request Sep 17, 2019

Require PHP 5.6+ #2527

Merged

Alkarex mentioned this pull request Oct 5, 2019

PostgreSQL 9.5+ #2554

Merged

Alkarex mentioned this pull request Oct 22, 2019

Take advantage of PHP 5.4+ short echo #2585

Merged

This was referenced Oct 23, 2019

Better performance with yield #2588

Merged

FreshRSS 1.15 #2599

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Require PHP 5.5+#2495

Require PHP 5.5+#2495
Alkarex merged 4 commits intoFreshRSS:devfrom
Alkarex:require_php5.5

Alkarex commented Aug 17, 2019 •

edited

Loading

Uh oh!

Alkarex commented Aug 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alkarex commented Aug 19, 2019 •

edited

Loading

Uh oh!

Frenzie commented Aug 19, 2019

Uh oh!

Alkarex commented Aug 19, 2019

Uh oh!

marienfressinaud commented Aug 20, 2019

Uh oh!

Uh oh!

Alkarex commented Sep 16, 2019

Uh oh!

Frenzie commented Sep 16, 2019

Uh oh!

marienfressinaud commented Sep 17, 2019

Uh oh!

Alkarex commented Sep 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Alkarex commented Aug 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alkarex commented Aug 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alkarex commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frenzie commented Aug 19, 2019

Uh oh!

Alkarex commented Aug 19, 2019

Uh oh!

marienfressinaud commented Aug 20, 2019

Uh oh!

Uh oh!

Alkarex commented Sep 16, 2019

Uh oh!

Frenzie commented Sep 16, 2019

Uh oh!

marienfressinaud commented Sep 17, 2019

Uh oh!

Alkarex commented Sep 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alkarex commented Aug 17, 2019 •

edited

Loading

Alkarex commented Aug 19, 2019 •

edited

Loading