[CI] Add PHP 7.3 to Travis configuration#2317
Merged
Alkarex merged 1 commit intoFreshRSS:devfrom Apr 1, 2019
Merged
Conversation
This also requires an update of phpcs, since the old version won't run on PHP 7.3. By setting setting the tab-width to 40 it works around the behavior introduced in squizlabs/PHP_CodeSniffer#1404 which erroneously interprets positioning spaces as indentation. ("If the line started with tabs, but had spaces after that, no error was thrown at all.") That makes any line lengths checks ineffective, but I think line length checks aren't very useful anyway. They're basically just a (very!) rough indication that you might want to consider some refactoring.
Merged
Alkarex
reviewed
Feb 25, 2021
| <description>Created with the PHP Coding Standard Generator. https://edorian.github.com/php-coding-standard-generator/</description> | ||
| <!-- to circumvent https://github.com/squizlabs/PHP_CodeSniffer/pull/1404 --> | ||
| <!--<arg name="tab-width" value="10"/>--> | ||
| <arg name="tab-width" value="40"/> |
Member
There was a problem hiding this comment.
@Frenzie Since this workaround, have you seen anything better?
I am giving a try to https://marketplace.visualstudio.com/items?itemName=ikappas.phpcs in Visual Studio Code, and it would be nice to <arg name="tab-width" value="40"/>
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
This also requires an update of phpcs, since the old version won't run on PHP 7.3. By setting setting the tab-width to 40 it works around the behavior introduced in squizlabs/PHP_CodeSniffer#1404 which erroneously interprets positioning spaces as indentation. ("If the line started with tabs, but had spaces after that, no error was thrown at all.") That makes any line lengths checks ineffective, but I think line length checks aren't very useful anyway. They're basically just a (very!) rough indication that you might want to consider some refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also requires an update of phpcs, since the old version won't run on PHP 7.3.
By setting setting the tab-width to 40 it works around the behavior introduced in squizlabs/PHP_CodeSniffer#1404 which erroneously interprets positioning spaces as indentation. ("If the line started with tabs, but had spaces after that, no error was thrown at all.")
That makes any line length checks ineffective, but I think line length checks aren't very useful anyway. They're basically just a (very!) rough indication that you might want to consider some refactoring.