Merged
Conversation
aledeg
commented
Mar 23, 2019
| $pow = min($pow, count($units) - 1); | ||
| $bytes /= pow($base, $pow); | ||
| return format_number($bytes, $precision) . ' ' . $units[$pow]; | ||
| return format_number($bytes, $precision) . ' ' . $units[$pow]; |
Member
Author
There was a problem hiding this comment.
I've changed this space because it wasn't a regular space. I don't know if it was on purpose or not. The space was coded on two bytes and broke the cli display layout.
Member
There was a problem hiding this comment.
It was on purpose, but if it broke anything, it is not a problem to remove it
Member
Author
There was a problem hiding this comment.
What was the use case which needed such space?
Member
There was a problem hiding this comment.
thin non-breaking space, if I remember correctly, which is the typographic standard between a number and its unit.
Now there is a switch to display the header on user info. While doing that, I've changed how the command is working to display all users by default and to accept more than one user at once. I also changed the display to make it more pleasing. As this command displays all users by default. I wonder if we still need the list user command. See FreshRSS#2294
aledeg
force-pushed
the
feature/cli-headers
branch
from
dd959b1 to
732cc37
Compare
Merged
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
May 8, 2020
Anf update documentation after FreshRSS#2296
Alkarex
added a commit
that referenced
this pull request
May 11, 2020
* Add lang and mail in CLI user-info Anf update documentation after #2296 * iff and language
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Add header to cli Now there is a switch to display the header on user info. While doing that, I've changed how the command is working to display all users by default and to accept more than one user at once. I also changed the display to make it more pleasing. As this command displays all users by default. I wonder if we still need the list user command. See FreshRSS#2294 * Minor format
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there is a switch to display the header on user info.
While doing that, I've changed how the command is working to display
all users by default and to accept more than one user at once.
I also changed the display to make it more pleasing.
As this command displays all users by default. I wonder if we still
need the list user command.
See #2294