Merged
Conversation
Closed
Frenzie
reviewed
Nov 10, 2018
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
These encoding changes wouldn't cause any trouble elsewhere?
Member
|
Pardon, I just saw the comment stating that it's technically a bug. GH had cleverly hidden the full commit message from my view. |
Member
Author
|
@Frenzie Those changes should not break existing clients. But additional tests very much welcome. We need to try:
Note: the version in FreshRSS's database is always the HTML-escaped version. |
Member
Author
|
It is a mess for News+, which decodes some HTML entities, but not all of them... But is it not worse than the situation before my changes. |
Alternative approach to encode XML special characters and other problematic characters into their Unicode fullwidth version when we cannot use HTML-encoding because clients disagree wether they should HTML-decode or not. FreshRSS#2091 (comment)
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Nov 12, 2018
Use only minimal XML->Unicode encoding for articles title. Follow-up of FreshRSS#2093
Merged
Alkarex
added a commit
that referenced
this pull request
Nov 12, 2018
Use only minimal XML->Unicode encoding for articles title. Follow-up of #2093
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Nov 14, 2018
Merged
Alkarex
added a commit
that referenced
this pull request
Dec 16, 2018
* Documentation Vienna / Open Reader #2091 #2093 ViennaRSS/vienna-rss#1197 * Remove references to Open Reader API for now
Merged
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Tweaks for Vienna RSS FreshRSS#2091 ViennaRSS/vienna-rss#1197 * Fix get feed by URL * Fix get item ids returning starred elements * API add item ids by feed URL * Add API filter `it` https://feedhq.readthedocs.io/en/latest/api/reference.html#stream-items-ids * API add `nt=` filter + refactoring * No ; prefix for author FreshRSS#2091 (comment) * Add id long form prefix and accept short id form FreshRSS#2091 (comment) * Fix quote problem FreshRSS#2091 (comment) * Isolate bug fix for News+ FreshRSS#2091 (comment) * Rework encoding conventions FreshRSS#2091 (comment) * Unicode escaping alternative Alternative approach to encode XML special characters and other problematic characters into their Unicode fullwidth version when we cannot use HTML-encoding because clients disagree wether they should HTML-decode or not. FreshRSS#2091 (comment)
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
Use only minimal XML->Unicode encoding for articles title. Follow-up of FreshRSS#2093
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Documentation Vienna / Open Reader FreshRSS#2091 FreshRSS#2093 ViennaRSS/vienna-rss#1197 * Remove references to Open Reader API for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2091
ViennaRSS/vienna-rss#1197