Merged
Conversation
Fix config & extensions pages; experimental fix for over-length menu options
Member
|
Thanks @pattems , great work 👍
P.S.: |
make swage.css readable.
prevent a dropdown menu item from wrapping multiple lines
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Fix Config pages in Swage Theme Fix config & extensions pages; experimental fix for over-length menu options * unminify Swage CSS make swage.css readable. * Update template.css prevent a dropdown menu item from wrapping multiple lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the config pages for the Swage them. I wasn't able to duplicate the menu-width issue referenced here: #2069 (comment)
All the same, I believe I've fixed that issue.
.dropdown-menu > .item > a, .dropdown-menu > .item > .as-link, .dropdown-menu > .item > span(lines 239-245 of template.css) specifies a minimum-width for the dropdown menu and menu items, but still allows for wrapping on whitespace, so over-length lines will wrap.Before:
After:
I only fixed this in my Swage theme so far, but I'd be happy to make the change to the template.css files across all themes to prevent any potential line wrapping from happening, if the intent is that each menu item should occupy no more than one line in a dropdown menu.