Merged
Conversation
Frenzie
reviewed
Oct 21, 2018
| * '_' is a reserved internal username. | ||
| */ | ||
| const USERNAME_PATTERN = '[0-9a-zA-Z_]{2,38}|[0-9a-zA-Z]'; | ||
| const USERNAME_PATTERN = '[0-9a-zA-Z_][0-9a-zA-Z_.]{1,38}|[0-9a-zA-Z]'; |
Member
There was a problem hiding this comment.
In MySQL I note that this means all identifiers should be quoted since only these are permitted in unquoted:
I'm not sure if hat could cause any issues at this point in time?
ASCII: [0-9,a-z,A-Z$_] (basic Latin letters, digits 0-9, dollar, underscore)
Member
Author
There was a problem hiding this comment.
We do quote identifiers for MySQL / SQLite / PostgreSQL so that should be fine (require quick testing)
Alkarex
added a commit
that referenced
this pull request
Oct 25, 2018
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Allow dot in username FreshRSS#2061 * Missing quotes for special chars in PostgreSQL
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2061