Skip to content

Escape cron step values with backslash#2032

Merged
Alkarex merged 2 commits intoFreshRSS:devfrom
jaltek:patch-1
Sep 28, 2018
Merged

Escape cron step values with backslash#2032
Alkarex merged 2 commits intoFreshRSS:devfrom
jaltek:patch-1

Conversation

@jaltek
Copy link
Copy Markdown
Contributor

@jaltek jaltek commented Sep 26, 2018

As I had this error myself I propose the following change:
Escape cron step values with backslash in $CRON_MIN.

Otherwise you will get the error sed: bad option in substitution expression.

Escape cron step values with backslash in $CRON_MIN
@Alkarex Alkarex changed the base branch from master to dev September 26, 2018 11:18
@Alkarex Alkarex added this to the 1.12.0 milestone Sep 26, 2018
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Sep 26, 2018

Thanks for the bug report 👍

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Sep 26, 2018

@jaltek I have changed the sed delimiter to avoid having to escape slashes.
Could you please double-check that it works fine for you? 7546ec4

@jaltek
Copy link
Copy Markdown
Contributor Author

jaltek commented Sep 28, 2018

@Alkarex Yes, works fine for me 👍

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Sep 28, 2018

Thanks for the feedback :-)

@Alkarex Alkarex merged commit 3ae1b57 into FreshRSS:dev Sep 28, 2018
Alkarex added a commit that referenced this pull request Sep 30, 2018
@Alkarex Alkarex mentioned this pull request Oct 14, 2018
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Escape cron step values with backslash

Escape cron step values with backslash in $CRON_MIN

* Change sed delimiter to allow unescaped slashes
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants