Merged
Conversation
Member
Author
|
First draft |
And uppercase SQL types
Member
Author
|
|
Member
Author
|
|
aledeg
reviewed
Sep 17, 2018
Member
Author
|
Now with the possibility to add new tags:
|
Member
Author
|
If someone tried this branch, the last commit introduces a new field. Either drop the tag tables (which will be re-created automatically), or add the field with: ALTER TABLE freshrss_alice_tag ADD COLUMN attributes TEXT; |
aledeg
requested changes
Sep 20, 2018
FreshRSS#2027 (comment) (I would have personnally prefered keeping the readability of a real value instead of a constant, in this case of many SQL fields)
Member
Author
|
TODO:
|
This was referenced Sep 23, 2018
Closed
Member
|
Nice work @Alkarex |
Member
Author
|
Thanks @aledeg , I hope you will like it :-) |
Add SQL check that tag names must be distinct from category names
Member
Author
|
Google Reader API implemented. Fully functional with News+:
|
Member
Author
|
Now also with some basic support in EasyRSS (only to read, not to add tags): |
Problematic parentheses
PostgreSQL needs some additional type hint to avoid "could not determine data type of parameter $1" http://www.postgresql-archive.org/Could-not-determine-data-type-of-parameter-1-tp2171092p2171094.html
Closed
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* First draft of custom tags FreshRSS#928 FreshRSS#1367 * SMALLINT to BIGINT for id_entry And uppercase SQL types * Fix layout for unreads * Start UI menu * Change menu order * Clean database helpers FreshRSS#2027 (comment) * Travis rules do not understand PostgreSQL constants Grrr * Tag controller + UI * Add column attributes to tags * Use only favicon for now, for label * Fix styling for different themes * Constant for maximum InnoDB index length in Unicode FreshRSS#2027 (comment) (I would have personnally prefered keeping the readability of a real value instead of a constant, in this case of many SQL fields) * Use FreshRSS_Factory::createCategoryDao * Add view of all articles containing any tag * Fix search in tags * Mark as read tags * Partial auto-update unread tags * More auto update tag unreads * Add tag deletion * Do not purge tagged articles * Minor comment * Fix SQLite and UI bug * Google Reader API support for user tags Add SQL check that tag names must be distinct from category names * whitespace * Add missing API for EasyRSS * Compatibility SQLite Problematic parentheses * Add SQL DISTINCT for cases with multiple tags * Fix for PostgreSQL PostgreSQL needs some additional type hint to avoid "could not determine data type of parameter $1" http://www.postgresql-archive.org/Could-not-determine-data-type-of-parameter-1-tp2171092p2171094.html
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Sep 10, 2023
Should help with some DB lock issues. Complete FreshRSS#3558 after FreshRSS#5625 already cherry-picked from it. * Removed auto-update of MySQL GUID case sensitivity FreshRSS#2078 * Contributed to a DB lock in FreshRSS#5008 Also removed the following non-problematic auto-updates, simply because they were older than the above ones * Auto-create custom labels (1.12.0) FreshRSS#2027 * Auto-add JSON column for feeds (1.11.0) FreshRSS#1838 * Auto-create temporary tables (1.7.0) FreshRSS#1470
Alkarex
added a commit
that referenced
this pull request
Sep 12, 2023
Should help with some DB lock issues. Complete #3558 after #5625 already cherry-picked from it. * Removed auto-update of MySQL GUID case sensitivity #2078 * Contributed to a DB lock in #5008 Also removed the following non-problematic auto-updates, simply because they were older than the above ones * Auto-create custom labels (1.12.0) #2027 * Auto-add JSON column for feeds (1.11.0) #1838 * Auto-create temporary tables (1.7.0) #1470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#928
#1367