Merged
Conversation
Frenzie
reviewed
Sep 1, 2018
app/i18n/en/feedback.php
Outdated
| 'sub' => array( | ||
| 'actualize' => 'Updating', | ||
| 'articles' => array( | ||
| 'marked_read' => 'The articles have been marked as read.', |
Member
There was a problem hiding this comment.
The selected articles have been marked as read?
Frenzie
reviewed
Sep 1, 2018
Frenzie
approved these changes
Sep 1, 2018
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
I'll toss in a follow-up PR for the Dutch translation if you prefer. :-)
Frenzie
reviewed
Sep 1, 2018
| 'search' => htmlspecialchars_decode(FreshRSS_Context::$search, ENT_QUOTES), | ||
| 'state' => FreshRSS_Context::$state, | ||
| ) | ||
| ), |
Member
There was a problem hiding this comment.
I always get annoyed by languages that don't allow this. ;-)
In order to prevent erroneous marking-as-unread. We might find a better logic later.
Member
Author
|
I have disabled mark-as-unread when read articles are not shown. |
To make it easier to discover
Member
Author
|
|
Member
Author
|
@Frenzie Ready for translation PR ;-) |
Alkarex
added a commit
that referenced
this pull request
Sep 3, 2018
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Sep 8, 2018
Regression from FreshRSS#1995
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Add mark-as-unread FreshRSS#1966 * Change sentence FreshRSS#1995 (comment) * Enable mark-as-unread only when unread articles are shown In order to prevent erroneous marking-as-unread. We might find a better logic later. * Disable instead of hide mark-as-unread option To make it easier to discover
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
Regression from FreshRSS#1995
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jul 22, 2022
Merged
Alkarex
commented
Jul 22, 2022
| if (!$get) { | ||
| // No get? Mark all entries as read (from $id_max) | ||
| $entryDAO->markReadEntries($id_max); | ||
| $entryDAO->markReadEntries($id_max, $is_read); |
Alkarex
added a commit
that referenced
this pull request
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1966