Skip to content

bottom padding to enable scroll to mark all as read #1980

Merged
Alkarex merged 2 commits intoFreshRSS:devfrom
primaeval:scroll
Aug 23, 2018
Merged

bottom padding to enable scroll to mark all as read #1980
Alkarex merged 2 commits intoFreshRSS:devfrom
primaeval:scroll

Conversation

@primaeval
Copy link
Copy Markdown
Contributor

100vh bottom padding to enable scrolling to mark as read and a 100% fallback for ancient browsers.

It works on the desktop (Windows Firefox and Chrome) and mobile (Android Firefox and Chrome). Mobile needed the 100vh version, desktop was ok with just the 100% version.

You can stop scrolling when you see the button if you want the original behaviour.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Aug 12, 2018

You should merge into dev, not master. But what does scroll to mark as read mean? It sounds undesirable to me.

@primaeval primaeval changed the base branch from master to dev August 12, 2018 15:04
@primaeval
Copy link
Copy Markdown
Contributor Author

You're the one who suggested this fix. ;) #1974 I've just rearranged my repo to get rid of the other ideas for a fix.

It means if you turn on "Settings \ Reading \ Mark article as read… \ while scrolling" you can scroll past the last article to mark All articles read. Without the fix the last few articles would not get marked and you have to manually press the "Mark All As Read" button. It is how Feedly works and how most people expect apps to work these days in my experience. Once you scroll past something you want to mark that you have seen it so you don't waste your time reading it again.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Aug 12, 2018

I only commented on the odd complexities involved in adding some padding.

So your title is deceptive and it's just a bug fix for a feature I don't like. ;-)

@primaeval
Copy link
Copy Markdown
Contributor Author

The important word in the title is "all". If FreshRSS has a feature to "mark article as read" "while scrolling" it should really finish the job and mark "all" the articles read, in my opinion.

I can't see what is wrong with the travis build. Is it something I've done or not done?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Aug 12, 2018

You can't see the details? It's just some Travis breakage on PHP 5.4 timing out, obviously nothing related to this PR. :-)

@Alkarex Alkarex added the UI 🎨 User Interfaces label Aug 23, 2018
@Alkarex Alkarex added this to the 1.12.0 milestone Aug 23, 2018
@Alkarex Alkarex merged commit 043d30c into FreshRSS:dev Aug 23, 2018
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 23, 2018

Alkarex added a commit that referenced this pull request Sep 1, 2018
@Alkarex Alkarex modified the milestones: 1.12.0, 1.11.2 Sep 3, 2018
@Alkarex Alkarex mentioned this pull request Oct 30, 2018
pattems added a commit to pattems/FreshRSS that referenced this pull request Oct 30, 2018
Remove theme sizing to make scroll as read work per FreshRSS#1980
Alkarex pushed a commit that referenced this pull request Oct 30, 2018
Remove theme sizing to make scroll as read work per #1980
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* bottom padding to enable scroll to mark all as read

* 100vh fallback for mobile
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Remove theme sizing to make scroll as read work per FreshRSS#1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants