bottom padding to enable scroll to mark all as read #1980
bottom padding to enable scroll to mark all as read #1980Alkarex merged 2 commits intoFreshRSS:devfrom
Conversation
|
You should merge into dev, not master. But what does scroll to mark as read mean? It sounds undesirable to me. |
|
You're the one who suggested this fix. ;) #1974 I've just rearranged my repo to get rid of the other ideas for a fix. It means if you turn on "Settings \ Reading \ Mark article as read… \ while scrolling" you can scroll past the last article to mark All articles read. Without the fix the last few articles would not get marked and you have to manually press the "Mark All As Read" button. It is how Feedly works and how most people expect apps to work these days in my experience. Once you scroll past something you want to mark that you have seen it so you don't waste your time reading it again. |
|
I only commented on the odd complexities involved in adding some padding. So your title is deceptive and it's just a bug fix for a feature I don't like. ;-) |
|
The important word in the title is "all". If FreshRSS has a feature to "mark article as read" "while scrolling" it should really finish the job and mark "all" the articles read, in my opinion. I can't see what is wrong with the travis build. Is it something I've done or not done? |
|
You can't see the details? It's just some Travis breakage on PHP 5.4 timing out, obviously nothing related to this PR. :-) |
|
Thanks @primaeval 👍 |
Remove theme sizing to make scroll as read work per FreshRSS#1980
Remove theme sizing to make scroll as read work per #1980
* bottom padding to enable scroll to mark all as read * 100vh fallback for mobile
Remove theme sizing to make scroll as read work per FreshRSS#1980
100vh bottom padding to enable scrolling to mark as read and a 100% fallback for ancient browsers.
It works on the desktop (Windows Firefox and Chrome) and mobile (Android Firefox and Chrome). Mobile needed the 100vh version, desktop was ok with just the 100% version.
You can stop scrolling when you see the button if you want the original behaviour.