Skip to content

fix active check in subscription menu#1858

Merged
Frenzie merged 2 commits intoFreshRSS:devfrom
kevinpapst:fix-subscription-menu
Apr 6, 2018
Merged

fix active check in subscription menu#1858
Frenzie merged 2 commits intoFreshRSS:devfrom
kevinpapst:fix-subscription-menu

Conversation

@kevinpapst
Copy link
Copy Markdown
Contributor

@kevinpapst kevinpapst commented Apr 1, 2018

The active check misbehaved:
when selecting the "Subscription tools" link, the "Subscriptions management" link was highlighted.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Apr 1, 2018

Ah, it took me like five seconds to understand where the problem even was but luckily there was the HTML. :-P

screenshot_2018-04-01_15-14-41

@kevinpapst
Copy link
Copy Markdown
Contributor Author

Ha, sorry for the confusion - I am using the german version and mistranslated the links in my original post (edited and now using the correct ones from your screenshot),

@Alkarex Alkarex added this to the 1.11.0 milestone Apr 4, 2018
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Apr 4, 2018

Minor syntax changes 8528b4d

@Alkarex Alkarex added the UI 🎨 User Interfaces label Apr 4, 2018
@kevinpapst
Copy link
Copy Markdown
Contributor Author

Any objections?

@Frenzie Frenzie merged commit 6b9be92 into FreshRSS:dev Apr 6, 2018
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Apr 6, 2018

I'll take the syntax update as implicit approval. ;-)

@kevinpapst
Copy link
Copy Markdown
Contributor Author

Thats what I thought as well :D

@kevinpapst kevinpapst deleted the fix-subscription-menu branch April 6, 2018 19:21
Alkarex added a commit that referenced this pull request Apr 26, 2018
@Alkarex Alkarex mentioned this pull request May 28, 2018
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants