Remove limitation on toggleContent#1647
Merged
Alkarex merged 1 commit intoFreshRSS:devfrom Sep 30, 2017
Merged
Conversation
Before, articles were repositioned only when the new and the old article were different. When they were the same, it was just closed. It was frustrating with long articles, especially during reading. Now, when an article is collapsed, it is repositionned no matter the collapsing method. This should fix FreshRSS#1177
Member
|
There's a setting I've disabled because I don't like it at all. (I sometimes like to click and highlight while reading.) But nice improvement to it. 👍 |
Contributor
|
It seems I cannot update:
Any idea to why? @Frenzie The problem is (hopefully was thanks to aledeg) here even with the setting disabled, when you use 'c' to collapse the article. |
Member
Author
|
I almost committed without fixing the collapsing mecanism :D |
Member
|
@Alwaysin Is it an error message from the Web interface? If yes, it is likely due to some local permission problems. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, articles were repositioned only when the new and the old article were different. When they were the same, it was just closed.
It was frustrating with long articles, especially during reading.
Now, when an article is collapsed, it is repositionned no matter the collapsing method.
This should fix #1177