Skip to content

Change layout for the share options on mobile#1645

Merged
Alkarex merged 2 commits intoFreshRSS:devfrom
aledeg:share-on-mobile
Sep 28, 2017
Merged

Change layout for the share options on mobile#1645
Alkarex merged 2 commits intoFreshRSS:devfrom
aledeg:share-on-mobile

Conversation

@aledeg
Copy link
Copy Markdown
Member

@aledeg aledeg commented Sep 27, 2017

Before, it was impossible to click on links to share on small screens.
Now, all dropdowns are opened at the bottom of the screen and stays there.

Linked to #1506

@aledeg
Change layout for the share options on mobile
3697e77 
Before, it was impossible to click on links to share on small screens.
Now, all dropdowns are opened at the bottom of the screen and stays there.

Linked to FreshRSS#1506
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Sep 27, 2017

Where is this dropdown menu? Whenever I see !important my spidey senses start tingling. :-P

@aledeg
Copy link
Copy Markdown
Member Author

aledeg commented Sep 27, 2017

@Frenzie I know :)
The dropdown menu are the one that you can see when you click on the share button and on the user queries. I used !important because I want to make sure that there is no radius on that dropdown since I display it at the bottom of the screen and it uses the whole space. The round corner was quite disgraceful.
Feel free to come with a better solution.

@Alkarex Alkarex added the UI 🎨 User Interfaces label Sep 27, 2017
@Alkarex Alkarex added this to the 1.7.1 milestone Sep 27, 2017
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Sep 27, 2017

Would it be possible to find a more qualified rule, hence avoiding the need of !important ?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Sep 27, 2017

I don't really want to figure out where this sharing thing is right now[1] but for the user query button you could increase specificity by using something like .dropdown .dropdown-menu.

[1] It looks like my settings say sharing in the bottom line but I suppose I'd have to set up some sharing for it to display.

@aledeg
Copy link
Copy Markdown
Member Author

aledeg commented Sep 27, 2017

@Frenzie @Alkarex Done. I removed the !important

@Alkarex Alkarex merged commit 47abdd0 into FreshRSS:dev Sep 28, 2017
@Alkarex Alkarex mentioned this pull request Sep 28, 2017
Closed
Alkarex added a commit that referenced this pull request Sep 28, 2017
@Alkarex
Changelog 1645
e53c10f 
#1645
@aledeg aledeg deleted the share-on-mobile branch September 29, 2017 04:58
@Alkarex Alkarex mentioned this pull request Sep 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

UI 🎨 User Interfaces

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@aledeg @Frenzie @Alkarex