Skip to content

Fix Illegal String Offset warning (PHP 7.1) in greader.php#1594

Merged
Alkarex merged 2 commits intoFreshRSS:devfrom
sandfoxme:patch-1
Jul 13, 2017
Merged

Fix Illegal String Offset warning (PHP 7.1) in greader.php#1594
Alkarex merged 2 commits intoFreshRSS:devfrom
sandfoxme:patch-1

Conversation

@arokettu
Copy link
Copy Markdown
Contributor

@arokettu arokettu commented Jul 12, 2017

greader.php throws Illegal String Offset warning because $ALL_HEADERS should be array not string

@Alkarex Alkarex added this to the 1.8.0 milestone Jul 13, 2017
@Alkarex Alkarex changed the base branch from master to dev July 13, 2017 09:34
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jul 13, 2017

Hello @sandfoxme
Many thanks for spotting and correcting this error.
Could you please use the classic syntax array() ? We are still supporting PHP 5.3.3.
I have changed the branch in the pull request (please use /dev and not /master)

@arokettu
Copy link
Copy Markdown
Contributor Author

@Alkarex done

@Alkarex Alkarex merged commit 16b269f into FreshRSS:dev Jul 13, 2017
@arokettu arokettu deleted the patch-1 branch July 13, 2017 13:46
Alkarex added a commit that referenced this pull request Jul 22, 2017
@Alkarex Alkarex modified the milestones: 1.8.0, 1.7.1 Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants