Skip to content

Make feedlist padding a bit dynamic#1589

Merged
Alkarex merged 1 commit intoFreshRSS:devfrom
romibi:ft-dynamic-feedlist-padding
Aug 19, 2017
Merged

Make feedlist padding a bit dynamic#1589
Alkarex merged 1 commit intoFreshRSS:devfrom
romibi:ft-dynamic-feedlist-padding

Conversation

@romibi
Copy link
Copy Markdown
Contributor

@romibi romibi commented Jun 21, 2017

With the fix #1489 (Bottom padding menu) for issue #1479 (UI: lowest subscription's popup gets hidden) now I had always a huge unnecessary space below the feed list while scrolling up… (about 1/3rd of the screen)

With this change I reduced the padding a lot (but not completely) and made sure that the padding is big enough again when a dropdown-menu is open to enable scrolling it into the field of view…

I think this is a good compromise…

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 21, 2017

Could you please make a screenshot of the original problem?

@Alkarex Alkarex added the UI 🎨 User Interfaces label Jun 21, 2017
@romibi
Copy link
Copy Markdown
Contributor Author

romibi commented Jun 21, 2017

How it looks without this PR for me:
https://gyazo.com/b7f0e7b5fec9afb9273a7f3e65a435af

@Alkarex Alkarex added this to the 1.8.0 milestone Jun 21, 2017
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 21, 2017

Ah, I see. Thanks 👍

@Alkarex Alkarex merged commit 771d3b5 into FreshRSS:dev Aug 19, 2017
Alkarex added a commit that referenced this pull request Aug 19, 2017
@Alkarex Alkarex modified the milestones: 1.8.0, 1.7.1 Aug 19, 2017
@romibi romibi deleted the ft-dynamic-feedlist-padding branch March 8, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants