Show full title of article when opened#1580
Show full title of article when opened#1580sjeon87 wants to merge 5 commits intoFreshRSS:masterfrom sjeon87:show-full-title-active-article
Conversation
|
TODO
|
|
I've always wanted this 👍 |
app/i18n/cz/conf.php
Outdated
| 'confirm_enabled' => 'Vyžadovat potvrzení pro akci “označit vše jako přečtené”', | ||
| 'display_articles_unfolded' => 'Ve výchozím stavu zobrazovat články otevřené', | ||
| 'display_categories_unfolded' => 'Ve výchozím stavu zobrazovat kategorie zavřené', | ||
| 'full_title' => 'Show the full title of the article when opened <small>(Title bar might look thicker)</small>', |
There was a problem hiding this comment.
Could you please add a //TODO at the end of this line and all others that requite a translation?
|
Ah, I should have noticed before: this is only relevant for the "origin-compact" theme, isn't it? Other themes already show the full title in the body of the article. E.g. |
|
Then, it's somewhat complex. My PR still works with other themes, but showing full title in other themes looks redundant. So it's a theme-dependent feature. I'll consider other ways to this end. (I think opt-in/out are needed because some people may like compact theme without full title) |
|
Without having checked the details, I would suggest you merge your CSS changes https://github.com/FreshRSS/FreshRSS/pull/1580/files#diff-ba1139aea9808c596c3bb85ce1b1233a with the |
|
Maybe @kevinpapst has some comments? |
|
If no opt-in/out are needed (but I think it should be careful, because it's compact theme!), I'll work on it. But if not, It rather not be merged. |
|
When I created the compact theme I removed the title on purpose from the body as it consumes rather much space and is (at least for me) in more than 90% of all feeds either not important or completely visible in the list. I would rather not re-add it. But we could probably have it in the HTML and use display:none as default. Or if it should be more user friendly: add a opt-in setting which works in all themes and toggles the title? |
|
@kevinpapst In this case, the title in the body would still be hidden, but the full title would be shown in the title bar even in the case of titles longer than one line |
|
The compact theme never displays the full title at all? Seems like a slightly odd decision to me. :-) I'm actually much more interested in having this prior to opening in any theme. (Yeah, yeah, I'm sure I can easily figure out the CSS but I'm just throwing it out there since someone's already on it.) Just compare EasyRSS and FreshRSS on my phone. The full title is only somewhat redundant after you've already read it. It's the only reason I use EasyRSS on my phone really, except for when I want to take along some articles offline (which only seems to work out half the time anyway). |
|
Last time I read this thread I might have misunderstood the PR. I don't think that we should keep the discussion focused on the compact theme:
Now what?
My preference: |
|
On desktop I'd also prefer to see the full title but it's even less important because a. Most of the title is generally showing regardless. But I don't necessarily mean the full title, just more of it. Exceeding five lines or so would become a bit much. Like how on good old Opera/Presto you had this experimental property: text-overflow: -o-ellipsis-lastline;Well, perhaps my interest is sufficiently piqued to experiment a little a few days from now. We don't have the CustomCSS extension for nothing. ;-) |
|
@Frenzie Please let us know the result of your experiments :-) |
|
None yet. I might've been too optimistic wrt my time. |
|
@Alkarex The README mentions "A recent browser like Firefox, Internet Explorer 11 / Edge, Chrome, Opera, Safari." but does that mean any concrete minimum? For example, flexbox could be interesting here besides regular CSS tabular stuff as already used. |
|
@Frenzie Good idea to use flexbox. I suggest for anybody interested in using more recent CSS features to just start a new theme. This way we can keep some legacy themes for some time, while having better layouts in new themes. We can write in the theme's description any higher requirement. |
|
I'm closing this PR because there's a bunch of conflicts and the approach needs to be improved. Also there's alternative thanks to the CustomCSS extension (see #2344 thread) |



I am subscribing some conference and journal feeds. Oftentimes, titles are a bit long. FreshRSS cuts the remained part away. Especially, it's hard to use FreshRSS on mobile phones. Added an option for it.
It looks like
Cons: Looks thick.