Skip to content

Show full title of article when opened#1580

Closed
sjeon87 wants to merge 5 commits intoFreshRSS:masterfrom
sjeon87:show-full-title-active-article
Closed

Show full title of article when opened#1580
sjeon87 wants to merge 5 commits intoFreshRSS:masterfrom
sjeon87:show-full-title-active-article

Conversation

@sjeon87
Copy link
Copy Markdown
Contributor

@sjeon87 sjeon87 commented Jun 10, 2017

I am subscribing some conference and journal feeds. Oftentimes, titles are a bit long. FreshRSS cuts the remained part away. Especially, it's hard to use FreshRSS on mobile phones. Added an option for it.

2017-06-10 9 35 23

It looks like

  • on PC

2017-06-10 9 37 33

  • on Mobile

screenshot_20170610-220718

Cons: Looks thick.

@sjeon87
Copy link
Copy Markdown
Contributor Author

sjeon87 commented Jun 10, 2017

TODO

  1. i18n for this feature is not complete. All i18n are written in English
  2. I've made 2 PR to the current dev branch. If both are merged, i18n/kr for this feature are needed.

@Alwaysin
Copy link
Copy Markdown
Contributor

I've always wanted this 👍
Especially useful with the minimal theme !

@Alkarex Alkarex added this to the 1.8.0 milestone Jun 10, 2017
@Alkarex Alkarex added the I18n 🌍 Translations label Jun 10, 2017
'confirm_enabled' => 'Vyžadovat potvrzení pro akci “označit vše jako přečtené”',
'display_articles_unfolded' => 'Ve výchozím stavu zobrazovat články otevřené',
'display_categories_unfolded' => 'Ve výchozím stavu zobrazovat kategorie zavřené',
'full_title' => 'Show the full title of the article when opened <small>(Title bar might look thicker)</small>',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a //TODO at the end of this line and all others that requite a translation?

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 10, 2017

Ah, I should have noticed before: this is only relevant for the "origin-compact" theme, isn't it? Other themes already show the full title in the body of the article. E.g.
image
I would then suggest to change the origin-compact theme with your patch
#1388

@Alkarex Alkarex added UI 🎨 User Interfaces and removed I18n 🌍 Translations labels Jun 10, 2017
@sjeon87
Copy link
Copy Markdown
Contributor Author

sjeon87 commented Jun 10, 2017

Then, it's somewhat complex. My PR still works with other themes, but showing full title in other themes looks redundant.

So it's a theme-dependent feature. I'll consider other ways to this end. (I think opt-in/out are needed because some people may like compact theme without full title)

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 10, 2017

Without having checked the details, I would suggest you merge your CSS changes https://github.com/FreshRSS/FreshRSS/pull/1580/files#diff-ba1139aea9808c596c3bb85ce1b1233a with the origin-compact theme.
P.S.: Meaning: always show the full title in this theme, without an option

@Alkarex Alkarex mentioned this pull request Jun 10, 2017
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 10, 2017

Maybe @kevinpapst has some comments?

@sjeon87
Copy link
Copy Markdown
Contributor Author

sjeon87 commented Jun 10, 2017

If no opt-in/out are needed (but I think it should be careful, because it's compact theme!), I'll work on it. But if not, It rather not be merged.

@kevinpapst
Copy link
Copy Markdown
Contributor

When I created the compact theme I removed the title on purpose from the body as it consumes rather much space and is (at least for me) in more than 90% of all feeds either not important or completely visible in the list. I would rather not re-add it.

But we could probably have it in the HTML and use display:none as default.
Interested users could then still use custom CSS rules to display it.

Or if it should be more user friendly: add a opt-in setting which works in all themes and toggles the title?

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 10, 2017

@kevinpapst In this case, the title in the body would still be hidden, but the full title would be shown in the title bar even in the case of titles longer than one line

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Jun 24, 2017

The compact theme never displays the full title at all? Seems like a slightly odd decision to me. :-) I'm actually much more interested in having this prior to opening in any theme. (Yeah, yeah, I'm sure I can easily figure out the CSS but I'm just throwing it out there since someone's already on it.) Just compare EasyRSS and FreshRSS on my phone. The full title is only somewhat redundant after you've already read it.

It's the only reason I use EasyRSS on my phone really, except for when I want to take along some articles offline (which only seems to work out half the time anyway).

2017-06-24 13 30 43
2017-06-24 13 30 44

@kevinpapst
Copy link
Copy Markdown
Contributor

kevinpapst commented Jun 24, 2017

Last time I read this thread I might have misunderstood the PR.

I don't think that we should keep the discussion focused on the compact theme:

  • this PR affects all themes by bringing a new feature
  • if you want to see the full title before opening the article, then its not a big help to have the full title in the body => thats why I removed it from the body (redundancy)
  • the mobile view is probably not the best UX in any theme and this might be a small step for improvement => we should have a different discussion how to improve the UX in mobile view in general

Now what?

  1. Keep this PR as it is, add it as a new and theme independent feature
  2. Having this PR for compact only (@Alkarex how? this PR changes core features), but not without a toggle to turn it on and off

My preference:
I am not convinced the solution from this PR is a good fit for the current UX/UI concept but I totally understand that people want to see the full title - so give them the option to do so ... for any theme.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Jun 24, 2017

On desktop I'd also prefer to see the full title but it's even less important because

a. Most of the title is generally showing regardless.
b. It's easy enough to hover, which is not the case on mobile.

But I don't necessarily mean the full title, just more of it. Exceeding five lines or so would become a bit much. Like how on good old Opera/Presto you had this experimental property:

text-overflow: -o-ellipsis-lastline;

Well, perhaps my interest is sufficiently piqued to experiment a little a few days from now. We don't have the CustomCSS extension for nothing. ;-)

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jun 28, 2017

@Frenzie Please let us know the result of your experiments :-)

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Jun 28, 2017

None yet. I might've been too optimistic wrt my time.

@Alkarex Alkarex modified the milestones: 1.8.0, 1.7.1 Aug 19, 2017
@Alkarex Alkarex modified the milestones: 1.8.0, 1.7.1 Aug 20, 2017
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Sep 23, 2017

@Alkarex The README mentions "A recent browser like Firefox, Internet Explorer 11 / Edge, Chrome, Opera, Safari." but does that mean any concrete minimum? For example, flexbox could be interesting here besides regular CSS tabular stuff as already used.

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Using_CSS_flexible_boxes

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Sep 23, 2017

@Frenzie Good idea to use flexbox. I suggest for anybody interested in using more recent CSS features to just start a new theme. This way we can keep some legacy themes for some time, while having better layouts in new themes. We can write in the theme's description any higher requirement.

@Alkarex Alkarex modified the milestones: 1.11.0, 1.12.0 May 23, 2018
@Alkarex Alkarex modified the milestones: 1.12.0, 1.13.0 Oct 14, 2018
@Alkarex Alkarex modified the milestones: 1.13.0, 1.14.0 Dec 16, 2018
@Alkarex Alkarex modified the milestones: 1.13.1, 1.14.0 Dec 27, 2018
@Alkarex Alkarex modified the milestones: 1.14.0, 1.15.0 Mar 23, 2019
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jul 13, 2019

FreshRSS/Extensions#46

@Alkarex Alkarex modified the milestones: 1.15.0, 1.16.0 Sep 29, 2019
@Alkarex Alkarex modified the milestones: 1.15.0, 1.16.0 Oct 26, 2019
@marienfressinaud marienfressinaud changed the base branch from dev to master December 18, 2019 08:28
@marienfressinaud
Copy link
Copy Markdown
Member

I'm closing this PR because there's a bunch of conflicts and the approach needs to be improved. Also there's alternative thanks to the CustomCSS extension (see #2344 thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants