Skip to content

More uniform styling of A and BUTTON in drop-downs#1557

Merged
Alkarex merged 1 commit intoFreshRSS:devfrom
Alkarex:font-size-button-as-link
May 28, 2017
Merged

More uniform styling of A and BUTTON in drop-downs#1557
Alkarex merged 1 commit intoFreshRSS:devfrom
Alkarex:font-size-button-as-link

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented May 27, 2017

@Alkarex Alkarex added this to the 1.7.0 milestone May 27, 2017
@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 27, 2017

@Frenzie Please give it a try if you can

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 27, 2017

Not tonight; probably not till Tuesday.

@Alkarex Alkarex added the UI 🎨 User Interfaces label May 28, 2017
@Alkarex Alkarex merged commit 5706186 into FreshRSS:dev May 28, 2017
@Alkarex Alkarex deleted the font-size-button-as-link branch May 28, 2017 00:11
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 28, 2017

The font-size seems okay, but the alignment is off a fair bit in Fx. To get it to render the same as in other browsers it'd need something like this:

button::-moz-focus-inner {
    padding: 0;
    border: 0
}

I imagine this is part of the reason why so many fake link buttons exist.

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 28, 2017

@Frenzie I cannot immediately see the problem on my side. Could you please send a screenshot?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 28, 2017

screenshot_2017-05-28_11-42-37

I can't quite get at the bottom of it because the Fx web inspector seems to be broken for me and it's not showing me CSS rules properly (no, I'm not filtering anything).

Also see https://stackoverflow.com/questions/5517744/remove-extra-button-spacing-padding-in-firefox

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 28, 2017

With Firefox 53 on Windows 10:
image

With Firefox 52 on Ubuntu 17.04:
image

With Firefox 53 on Ubuntu 17.04:
image

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 28, 2017

I was able to see the problem with Firefox 52 on Ubuntu, but with the current version (53) of Firefox, I cannot reproduce the problem on Windows or Ubuntu.
Related Firefox issues:

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 28, 2017

The current Firefox ESR is 45 but since it's a minor visual glitch let's just ignore it then.

Edit: incidentally, on my Debian Stretch Fx is still at 52. I mistakenly thought it was the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants