Skip to content

fix font-sizes of input fields for exotic browsers#1550

Merged
Alkarex merged 4 commits intoFreshRSS:devfrom
mszkb:dev
May 28, 2017
Merged

fix font-sizes of input fields for exotic browsers#1550
Alkarex merged 4 commits intoFreshRSS:devfrom
mszkb:dev

Conversation

@mszkb
Copy link
Copy Markdown

@mszkb mszkb commented May 26, 2017

There was no Placeholder inside input fields. Also the written text inside password-fields and adding subscription were super small (font-size: 0; inherited from .stick origine.css:115)

See my comment below for screenshots.

@Alkarex Alkarex added the UI 🎨 User Interfaces label May 26, 2017
@Alkarex Alkarex added this to the 1.7.0 milestone May 26, 2017
input, select, textarea {
display: inline-block;
max-width: 100%;
font-size: inital;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo: it is initial ;-)

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 26, 2017

@mszkb
Copy link
Copy Markdown
Author

mszkb commented May 26, 2017

Oh yes, stupid me. Fixed in 20281fb

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 26, 2017

Actually, the font-size: initial; makes input fields quite larger. It would be nice to find a fix that corrects the problem in QupZilla without changing too much the rendering in other browsers:

Before (in Firefox):

image

After:

image

@mszkb
Copy link
Copy Markdown
Author

mszkb commented May 26, 2017

Hmmm, to fix this issue on all browsers, it needs a reset.
If changing the font-size to 15px, the fonts on Chrome gets bigger (13.3333px default on chrome).

Firefox and Chrome ignore the font-size from .post origine.css:635 and .stick origine.css:115. They take the fallback to the user agents default. QubZilla inherites font-size: 0 from .stick.
Not sure if this comes from the special implementation of QubZillas rendering engine or the correct interpretation.

Anyway.. It would be your call to risk a reset of the font-size or ignore it, due to low user count of QubZilla.

.tree {
margin: 0;
padding: 0 0 15em 0;
padding: 0;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for this change?
#1489

input, select, textarea {
display: inline-block;
max-width: 100%;
font-size: initial;
Copy link
Copy Markdown
Member

@Alkarex Alkarex May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest trying with font-size: 0.8rem; instead.

@Alkarex Alkarex merged commit 2b0c910 into FreshRSS:dev May 28, 2017
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 28, 2017

@mszkb Trying with font-size: 0.8rem;. Let me know how it works on your side.
Quick merge to test the /dev branch prior to 1.7 release.
#1548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants