Option for not closing article after pressing outside article area#1539
Merged
Alkarex merged 10 commits intoFreshRSS:devfrom May 26, 2017
psukys:dev
Merged
Option for not closing article after pressing outside article area#1539Alkarex merged 10 commits intoFreshRSS:devfrom psukys:dev
Alkarex merged 10 commits intoFreshRSS:devfrom
psukys:dev
Conversation
…ult settings and translation entry for English
Member
|
Let's try to make some more translations (I will do a few) |
hoilc
added a commit
to hoilc/FreshRSS
that referenced
this pull request
May 23, 2017
Alkarex
reviewed
May 25, 2017
| 'display_categories_unfolded' => 'Show categories folded by default', | ||
| 'hide_read_feeds' => 'Hide categories & feeds with no unread articles (does not work with “Show all articles” configuration)', | ||
| 'img_with_lazyload' => 'Use "lazy load" mode to load pictures', | ||
| 'sides_close_article' => 'Clicking outside of article text area closes the article', |
Member
There was a problem hiding this comment.
Could you please add this line to all other languages, suffixed with a TODO?
'sides_close_article' => 'Clicking outside of article text area closes the article', //TODO
Member
Contributor
Author
|
@Alkarex added the line to other languages with TODO comment. Also added myself to credits |
Member
|
Thanks @psukys ! |
Member
|
Awesome! I never liked that but my annoyance with it was extremely minor. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional configuration setting for #1530 . This includes default settings and translation entry for English.