Conversation
|
Will also address FreshRSS/Extensions#15 |
|
Looks like it is not working. I know get a "404 not found" in the app even though http://freshrss/api/ttrss.php is working (I have removed the extension). |
|
What do you get in your HTTP logs? |
|
Strange things for Newsjet: and TTRSS: I don't know why there is an added "/api/'... Nothing in error.log and nothing in FreshRSS logs apparently. |
Fix MySQL bug, optimize some queries, fix type bug.
|
@Alwaysin The app NewsJet seems to work for me with the commit I have just done. |
|
P.S.: You might have to log out, clear the app, and start NewsJet again. |
|
P.S. It looks like a few more APIs calls will be needed to get NewsJet to work fully. |
|
Damn, it still won't work. I'll try to see why. |
|
Some TT-RSS clients only support 32-bit article IDs, and FreshRSS is using 64-bit article IDs. We might have to do some changes if we want to support those clients. |
|
What do you think @marienfressinaud , @aledeg ?
|
|
Is TTRSS officially support 64-bit IDs? If not, I would prefer option 3 but adding a new column just for an API is frustrating… If it's too much work, option 1 is not so bad since the plugin has always been in a work-in-progress state. |
|
I do not think it would be so much work with the new column, and it would enable compatibility with a good number of clients. To compensate for the "cost" of adding a column, we could try to take advantage of the shorter article ID in other places. |
Do not use blind `call_user_func`, validate username, limit POST input size
And use FreshRSS_Context like in other similar places
|
I have just updated this branch so that it is functional again (tested with NewsJet), and in line with the latest changes in the rest of the FreshRSS code.
Adding a 32-bit column would not be a big deal either. It would be motivating to list a few (good) clients that are supporting the TT-RSS API but not the Google Reader API (for self-hosted) |
|
I assume this one doesn't support GReader. I haven't tried it but it seems to have decent ratings on Google Play. |
|
It's weird to see that PR. Instead of including extension in the core, I would go the other way around and extract things as extension. This way, FreshRSS can be lightweight for when you don't need the bells and whistles. For instance, I'd like to have views (normal, global, reading) as extensions to only install the one I am using. But I would love to enable different views (to be created). Same goes with the APIs since I am not using them. But for sure, to be able to do that we need few things:
My 2¢ |
|
I agree that for something like this a core extension seems like it could make sense, but lightweight strikes me as an argument that's unlikely to be valid. Maybe if you don't have opcache and it'd have to be parsed again and again? But I hardly think we should optimize for such a scenario. ;-) The number of APIs is and will remain extremely limited, and it's not like they're any easier or harder to implement one way or the other. |
|
My point was more to have a modular architecture which makes more sense when the range of use is really wide. We cannot address all of them so maybe we can have more extension contributors. |
|
This feature requires some changes in the core, if we were to implement it fully. Afterwards, it can be a standalone file like the other APIs. |
|
The app I'd like to be able to use this api with is newsboat, which as it stands I can't get to work with freshrss - of course, that's not a phone app! |
It was not working, and has not been maintained in a long time. A follow-up was started on FreshRSS/FreshRSS#1526 as it would require changes in the core for proper support. But if anybody was using this extension for anything, reach out :-)
It was not working, and has not been maintained in a long time. A follow-up was started on FreshRSS/FreshRSS#1526 as it would require changes in the core for proper support. But if anybody was using this extension for anything, reach out :-)

Into FreshRSS code
https://github.com/FreshRSS/Extensions/tree/master/xExtension-TTRSS_API
From @marienfressinaud