1464 Improve English Translations#1465
Merged
Alkarex merged 6 commits intoFreshRSS:devfrom Mar 26, 2017
jlefler:1464-improve-english-translations
Merged
1464 Improve English Translations#1465Alkarex merged 6 commits intoFreshRSS:devfrom jlefler:1464-improve-english-translations
Alkarex merged 6 commits intoFreshRSS:devfrom
jlefler:1464-improve-english-translations
Conversation
Release 1.6.3
…ce for english-speaking users.
Alwaysin
suggested changes
Mar 21, 2017
app/i18n/en/conf.php
Outdated
| 'article_action' => 'Article actions', | ||
| 'auto_share' => 'Share', | ||
| 'auto_share_help' => 'If there is only one sharing mode, it is used. Else modes are accessible by their number.', | ||
| 'auto_share_help' => 'If there is only one sharing mode, it is used. Other modes are accessible by their number.', |
Contributor
There was a problem hiding this comment.
I think that "else" was used as in "otherwise" here - not "other", which would make more sense.
Contributor
Author
|
I'm fine with otherwise rather than other here.
…On Tue, Mar 21, 2017, 16:19 Alwaysin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In app/i18n/en/conf.php
<#1465 (comment)>:
> @@ -142,7 +142,7 @@
'_' => 'Shortcuts',
'article_action' => 'Article actions',
'auto_share' => 'Share',
- 'auto_share_help' => 'If there is only one sharing mode, it is used. Else modes are accessible by their number.',
+ 'auto_share_help' => 'If there is only one sharing mode, it is used. Other modes are accessible by their number.',
I think that "else" was used as in "otherwise" here - not "other", which
would make more sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1465 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFTreZ2ntx7DsPkxNyjyCx48fuYwlMKks5roD7sgaJpZM4MkGHC>
.
|
aledeg
reviewed
Mar 22, 2017
app/i18n/en/admin.php
Outdated
| 'percent_of_total' => '%% of total', | ||
| 'repartition' => 'Articles repartition', | ||
| 'status_favorites' => 'Favourites', | ||
| 'status_favorites' => 'Favorites', |
Member
There was a problem hiding this comment.
Both are correct. One is for US, the other one is for UK. I have no preference even though I am more used to "Favourites"
Member
|
Look good to me. @jlefler thanks |
Add credits. Keep British spelling of favourites in the user interface, USA spelling in the code.
Member
|
Merged. Thanks again! |
Alkarex
reviewed
Apr 1, 2017
| return array( | ||
| 'action' => array( | ||
| 'actualize' => 'Actualize', | ||
| 'actualize' => 'Updating', |
Member
There was a problem hiding this comment.
I think this one is wrong:
Should be something like Actualize or Update
Member
|
I would also change the "damn!" in error messages to something slightly more proper even if it's only a stylistic issue. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request has no functional changes. It merely updates the English translation with minor changes to word choice and grammar to improve the user experience for English-speaking users. The incorrect translation that prompted the change was 'Actualise' when performing a feed update. I have replaced that with "Updating" and made other similar changes. Fixes #1464.