Prevent a target _blank attacks with window.opener#1246
Merged
Alkarex merged 2 commits intoFreshRSS:devfrom Sep 7, 2016
Merged
Prevent a target _blank attacks with window.opener#1246Alkarex merged 2 commits intoFreshRSS:devfrom
Alkarex merged 2 commits intoFreshRSS:devfrom
Conversation
https://mathiasbynens.github.io/rel-noopener/ noopener is implied by noreferrer https://html.spec.whatwg.org/multipage/semantics.html#link-type-noreferrer The API for window.open() does not seem stable yet https://bugzilla.mozilla.org/show_bug.cgi?id=1267339
Member
|
There is still a risk if a link from an article contains a |
Member
Author
|
If there is no existing |
Member
|
Oops, I didn't pay attention to that line! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1245
https://mathiasbynens.github.io/rel-noopener/
noopener is implied by noreferrer https://html.spec.whatwg.org/multipage/semantics.html#link-type-noreferrer
The API for window.open() does not seem stable yet https://bugzilla.mozilla.org/show_bug.cgi?id=1267339