Skip to content

Sticky sidebar#1172

Merged
Alkarex merged 1 commit intoFreshRSS:devfrom
romibi:stickySidebar
Aug 13, 2016
Merged

Sticky sidebar#1172
Alkarex merged 1 commit intoFreshRSS:devfrom
romibi:stickySidebar

Conversation

@romibi
Copy link
Copy Markdown
Contributor

@romibi romibi commented Jul 8, 2016

With lots of articles on one page, all expanded (how i like it), it was a bit inconvenient to change the feed…

I solved this by making the Sidebar sticky with a jQuery Plugin "Sticky-Kit"

For the plugin to work I needed to disable the defer and async on jQuery script tag.

I hope the "mobile check" is ok this way…

Before:
https://gyazo.com/2816b7b2a928a97a8bebe5277f04ea7d
After:
https://gyazo.com/059b66ce0590eb9cc96fa7e92e9abda5

(sorry for creating the PR twice … choose the wrong target branch first)

@marienfressinaud
Copy link
Copy Markdown
Member

@romibi
Copy link
Copy Markdown
Contributor Author

romibi commented Jul 8, 2016

ooh …
I didn't see the Extensions … sorry … (perhaps the Extensions should be linked in the main readme)

Thou i think this should be default … Therefore i'll keep this PR open for the moment …
Just close this if you don't think so …

@Alkarex Alkarex added the UI 🎨 User Interfaces label Jul 8, 2016
@Alkarex Alkarex mentioned this pull request Jul 30, 2016
@Alkarex Alkarex added this to the 1.5.1-beta milestone Aug 13, 2016
@Alkarex Alkarex self-assigned this Aug 13, 2016
@Alkarex Alkarex merged commit d9e1462 into FreshRSS:dev Aug 13, 2016
Alkarex added a commit that referenced this pull request Aug 13, 2016
Alkarex added a commit that referenced this pull request Aug 13, 2016
And set correct parent option
#1172
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 13, 2016

@romibi Thanks 👍
I have merged your proposition, after a few changes a180485
Please give a try to the /dev branch of FreshRSS if you can

@romibi
Copy link
Copy Markdown
Contributor Author

romibi commented Aug 14, 2016

Nice, thanks…
Yes I'll give the dev branch a try once i find time … (I'm having exams the next few weeks)
Probably everything is ok 😄

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Aug 14, 2016
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 14, 2016

One more little change #1214 for recalc after auto loading more articles

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 14, 2016

I can see a little bug when collapsing the categories

@romibi
Copy link
Copy Markdown
Contributor Author

romibi commented Aug 14, 2016

sounds familiar and i think i fixed it … can't remember exactly … but wasn't that the reason why i added those 3 'false' to the jquery append script function?
don't really have time to test it at the moment …
the last few weeks i was testing the extension marienfressinaud mentioned instead of this modification … so i can't exactly remember if it worked 100% fine …

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 14, 2016

The tree false were to ensure that jQuery was loaded first. But I ensured another way (keeping async and defer) and this is not the reason for this bug.

@romibi romibi deleted the stickySidebar branch May 27, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants