Skip to content

CustomJS / CustomCSS - check file permissions#23

Merged
Alkarex merged 4 commits intoFreshRSS:masterfrom
kevinpapst:permission-info
Dec 13, 2017
Merged

CustomJS / CustomCSS - check file permissions#23
Alkarex merged 4 commits intoFreshRSS:masterfrom
kevinpapst:permission-info

Conversation

@kevinpapst
Copy link
Copy Markdown
Collaborator

@kevinpapst kevinpapst commented Dec 6, 2017

  • Adjusted CustomCSS and CustomJS
  • added file permission check and error message
  • extension config cannot be submitted until permission is fixed
  • added german translations
  • removed CustomCSS/static/style.css which was loaded by default, included a non-sense CSS rule and was not editable in the frontend

Fixes FreshRSS/FreshRSS#1456

@kevinpapst
Copy link
Copy Markdown
Collaborator Author

Calling out for @Alkarex and the grammar-eagle-eye @Frenzie ;-)

$current_user = Minz_Session::param('currentUser');
$filename = 'style.' . $current_user . '.css';
$filepath = join_path($this->getPath(), 'static', $filename);
$staticPath = join_path($this->getPath(), 'static');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh there's a new path thing. On phone atm.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I saw that, but a) its for 1.9 and b) its not usable right now: FreshRSS/FreshRSS#1709

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, cool.

@kevinpapst
Copy link
Copy Markdown
Collaborator Author

ping @Alkarex

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Dec 13, 2017

Sorry, I have a tendency to forget things in other repositories (one of the several reasons I would like to move this one under the main FreshRSS repository).
I have done the French translation.

@Alkarex Alkarex merged commit 2dada65 into FreshRSS:master Dec 13, 2017
@kevinpapst kevinpapst deleted the permission-info branch June 8, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom CSS and JS does not save anything

3 participants