Conversation
The imx-boot-container MACHINEOVERRIDES allows the bootloader recipe to enable the binman support for the SoCs which uses it. The conditional belongs to the bootloader recipe and can be removed from machines. Signed-off-by: Otavio Salvador <[email protected]>
The imx-boot-container is SoC specific so it should not be set inside the machine but in the BSP basic settings. This commit moves it to the imx-base.inc file as the bootloader recipe can still opt to not inherit the class specifically. Signed-off-by: Otavio Salvador <[email protected]>
Contributor
|
I think it makes sense. Note that the |
thochstein
approved these changes
Mar 29, 2023
Contributor
|
Actually, I think you should set |
Member
Author
This variable can be removed as well. The class would need more rework, but I prefer to do that as another PR so we don't mix changes. |
Member
Author
|
About limiting it to i.MX8M SoCs, @zandrey did most of this work. But first, we must verify which platforms already use Either way, we should first clean up this, and later, we can extend the functionality. |
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 4, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 10, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 10, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 14, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 24, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 26, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 27, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Apr 28, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 3, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 3, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 5, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 8, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 8, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 9, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 10, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
May 10, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jun 29, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jun 29, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jun 29, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jun 30, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jul 3, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jul 4, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jul 4, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jul 7, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jul 13, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jul 31, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Aug 3, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Aug 4, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to quaresmajose/meta-lmp
that referenced
this pull request
Aug 8, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Aug 8, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Aug 11, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Aug 28, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Aug 30, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Sep 4, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Sep 5, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Sep 6, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Sep 8, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Sep 18, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Sep 22, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 2, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 9, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 12, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 13, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 19, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 19, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 19, 2023
The imx-boot-container MACHINEOVERRIDES is now SoC specific [1] with higher prioririty than mx8-generic-bsp. The meta-freescale layer also check for 1/0 so set it to 0. [1] Freescale/meta-freescale#1465 Signed-off-by: Jose Quaresma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes two commits that make changes related to the
imx-boot-containerconfiguration.The first commit removes the conditional
imx-boot-containerMACHINEOVERRIDESfrom machines. The conditional belongs to the bootloader recipe and can be removed from machines to simplify the configuration.The second commit moves the
imx-boot-containerMACHINEOVERRIDESto extender as it is SoC specific and should not be set inside the machine. The commit moves it to theimx-base.incfile to ensure proper configuration.Together, these changes improve the configuration of
imx-boot-containerin our software project by removing unnecessary conditional statements from machines and moving the configuration to a more appropriate location.