vulkan-loader: iMX8M Mini doesn't support vulkan#1249
Merged
otavio merged 3 commits intoFreescale:masterfrom Oct 4, 2022
Merged
vulkan-loader: iMX8M Mini doesn't support vulkan#1249otavio merged 3 commits intoFreescale:masterfrom
otavio merged 3 commits intoFreescale:masterfrom
Conversation
otavio
requested changes
Oct 3, 2022
quaresmajose
force-pushed
the
vulkan-loader
branch
from
1a16159 to
d9a7ea2
Compare
otavio
approved these changes
Oct 3, 2022
Contributor
|
Note, there's a bigger issue here that we don't support the latest version of Vulkan. To get this working we also need to downgrade to 1.2.182. |
Member
|
The downgrade is for master only, right? |
Contributor
|
It's for |
quaresmajose
added a commit
to quaresmajose/meta-lmp
that referenced
this pull request
Oct 4, 2022
Vulkan is disabled on meta-freescale for 8M Mini since ee92b5a, so add the same logic to not recommends libvulkan-imx on this machines. Freescale/meta-freescale@ee92b5a This append is version specific because it's a workaround until upstream found and merge a solution then we can drop this patch. Freescale/meta-freescale#1249 This also fix: | ERROR: Nothing RPROVIDES 'libvulkan-imx' (but /srv/oe/build/conf/../../layers/openembedded-core/meta/recipes-graphics/vulkan/vulkan-loader_1.3.216.0.bb RDEPENDS on or otherwise requires it) | ERROR: Required build target 'lmp-base-console-image' has no buildable providers. | Missing or unbuildable dependency chain was: ['lmp-base-console-image', 'weston', 'virtual/libgles2', 'mesa', 'vulkan-loader', 'libvulkan-imx'] Signed-off-by: Jose Quaresma <[email protected]>
Contributor
|
I'm working on the downgrade. |
All iMX8 modules with the imxgpu override support Vulkan with a single exception for the iMX8M Mini that uses the mx8mm override. Vulkan is disabled on meta-freescale for 8M Mini since ee92b5a, so we create the imxvulkan override to use when Vulkan is supported. Sugested-by: Otavio Salvador <[email protected]> Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
vulkan-loader
branch
from
d9a7ea2 to
18c706c
Compare
quaresmajose
changed the title
otavio
requested changes
Oct 4, 2022
With this the libvulkan-imx is recommends only when the machine supports Vulkan. Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
vulkan-loader
branch
from
18c706c to
343f280
Compare
Signed-off-by: Jose Quaresma <[email protected]>
otavio
approved these changes
Oct 4, 2022
angolini
approved these changes
Oct 4, 2022
Contributor
|
Successfully created backport PR #1250 for |
thochstein
approved these changes
Oct 4, 2022
Contributor
thochstein
left a comment
thochstein
left a comment
There was a problem hiding this comment.
This looks good. I can always follow up if mesa-vulkan-drivers should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulkan is disabled on meta-freescale for 8M Mini since ee92b5a, so add the same logic to not recommends libvulkan-imx on this machines.
All iMX8 modules with the imxgpu override support Vulkan with a
single exception for the iMX8M Mini that uses the mx8mm override.
With this the libvulkan-imx is recommends only when the machine
supports Vulkan.
Signed-off-by: Jose Quaresma [email protected]