perf cs-etm: Move definition of 'traceid_list' global variable from h…#112
Merged
otavio merged 1 commit intoFreescale:5.4-2.1.x-imxfrom Aug 27, 2020
Merged
perf cs-etm: Move definition of 'traceid_list' global variable from h…#112otavio merged 1 commit intoFreescale:5.4-2.1.x-imxfrom
otavio merged 1 commit intoFreescale:5.4-2.1.x-imxfrom
Conversation
…eader file The variable 'traceid_list' is defined in the header file cs-etm.h, if multiple C files include cs-etm.h the compiler might complaint for multiple definition of 'traceid_list'. To fix multiple definition error, move the definition of 'traceid_list' into cs-etm.c. Fixes: cd8bfd8 ("perf tools: Add processing of coresight metadata") Reported-by: Thomas Backlund <[email protected]> Signed-off-by: Leo Yan <[email protected]> Reviewed-by: Mathieu Poirier <[email protected]> Reviewed-by: Mike Leach <[email protected]> Tested-by: Mike Leach <[email protected]> Tested-by: Thomas Backlund <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Suzuki Poulouse <[email protected]> Cc: Tor Jeremiassen <[email protected]> Cc: [email protected] Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> (cherry picked from commit 168200b)
Author
|
This is a cherry-pick from upstream, which solves the @rehsack I guess you would need to have the same for QorIQ kernel fork. -- andrey |
|
@zandrey thanks for the hint. I check it next time I update OE-core and will likely do some QorIQ kernel update than along the OE-core update :) |
otavio
approved these changes
Aug 27, 2020
Member
|
This need to be done to the other kernel versions we maintain, doesn't it? |
Author
Yes, I would prepare a separate PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eader file
The variable 'traceid_list' is defined in the header file cs-etm.h,
if multiple C files include cs-etm.h the compiler might complaint for
multiple definition of 'traceid_list'.
To fix multiple definition error, move the definition of 'traceid_list'
into cs-etm.c.
Fixes: cd8bfd8 ("perf tools: Add processing of coresight metadata")
Reported-by: Thomas Backlund [email protected]
Signed-off-by: Leo Yan [email protected]
Reviewed-by: Mathieu Poirier [email protected]
Reviewed-by: Mike Leach [email protected]
Tested-by: Mike Leach [email protected]
Tested-by: Thomas Backlund [email protected]
Cc: Alexander Shishkin [email protected]
Cc: Jiri Olsa [email protected]
Cc: Mark Rutland [email protected]
Cc: Namhyung Kim [email protected]
Cc: Peter Zijlstra [email protected]
Cc: Suzuki Poulouse [email protected]
Cc: Tor Jeremiassen [email protected]
Cc: [email protected]
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo [email protected]
(cherry picked from commit 168200b)