-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Hello,
I notice the following two problems caused by Uncrustify.
(1) There are some mistakes of indent.
(2) Single line comment starting with ';' is moved to the next line. This causes compile error.
For example, following changes had been made.
portable/Renesas/RX600v2/port.c
Before:
#pragma inline_asm prvYieldHandler
static void prvYieldHandler( void )
{
...omit...
/* Save the FPSW and accumulators. */
MVFC FPSW, R15
PUSH.L R15 <---- HERE and BELOW.
MVFACGU #0, A1, R15
PUSH.L R15
MVFACHI #0, A1, R15
PUSH.L R15
MVFACLO #0, A1, R15 ; Low order word. <---- HERE
PUSH.L R15
MVFACGU #0, A0, R15
PUSH.L R15
MVFACHI #0, A0, R15
PUSH.L R15
MVFACLO #0, A0, R15 ; Low order word. <---- HERE
PUSH.L R15
...omit...
}
After:
#pragma inline_asm prvYieldHandler
static void prvYieldHandler( void )
{
...omit...
/* Save the FPSW and accumulators. */
MVFC FPSW, R15
PUSH.L R15 <---- mistakes of indent. HERE and BELOW.
MVFACGU # 0, A1, R15
PUSH.L R15
MVFACHI # 0, A1, R15
PUSH.L R15
MVFACLO # 0, A1, R15;
Low order word. <---- This should be comment.
PUSH.L R15
MVFACGU # 0, A0, R15
PUSH.L R15
MVFACHI # 0, A0, R15
PUSH.L R15
MVFACLO # 0, A0, R15;
Low order word. <---- This should be comment.
PUSH.L R15
...omit...
}
Best regards,
NoMaY
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working