Fix issues in TCP QEMU Demo #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
reviewed
Mar 6, 2023
| { | ||
| BaseType_t x; | ||
|
|
||
| /*set Ethernet interrupt priority to configMAC_INTERRUPT_PRIORITY*/ |
Member
There was a problem hiding this comment.
Suggested change
| /*set Ethernet interrupt priority to configMAC_INTERRUPT_PRIORITY*/ | |
| /* Set Ethernet interrupt priority to configMAC_INTERRUPT_PRIORITY. */ |
aggarg
previously approved these changes
Mar 6, 2023
alfred2g
reviewed
Mar 6, 2023
| #define __CM3_REV 0x0201 /* Core revision r2p1 */ | ||
| #define __MPU_PRESENT 1 /* MPU present or not */ | ||
| #define __NVIC_PRIO_BITS 3 /* Number of Bits used for Priority Levels */ | ||
| #define __NVIC_PRIO_BITS 8 /* Number of Bits used for Priority Levels */ |
Contributor
There was a problem hiding this comment.
Can we avoid changing this file, as it is a copy from CMSDK library
Member
There was a problem hiding this comment.
This is needed because QEMU reports as all 8 bits implemented.
Contributor
There was a problem hiding this comment.
do we need to set a note somewhere if someone updates the library, to make the necessary changes ? (possibly in the readme)
Signed-off-by: Gaurav Aggarwal <[email protected]>
alfred2g
approved these changes
Mar 6, 2023
aggarg
approved these changes
Mar 6, 2023
Merged
moninom1
added a commit
that referenced
this pull request
Mar 7, 2023
* update the freertos + TCP demos to use the neew API for getting the UDP pyaload buffer [FreeRTOS_GetUDPPayloadBuffer_ByIPType] (#938) * Add CBMC proof-running GitHub Action (#924) * Added two config options to the FreeRTOSConfig file to get the demo running again. Fixed a typo in a file. Added a section to the link file (#940) * Create SMP on target test framework. (#911) * Fix CBMC proof failures (#946) These were introduced in PR #620. * Make static IP address configurable (#947) * Fix issues in TCP QEMU Demo (#948)
every-breaking-wave
pushed a commit
to every-breaking-wave/FreeRTOS
that referenced
this pull request
Nov 15, 2024
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
* Fix issues in TCP QEMU Demo * set the Ethernet interrupt priority * Include CMSIS header files to fix build issues * Review suggestion Signed-off-by: Gaurav Aggarwal <[email protected]> --------- Signed-off-by: Gaurav Aggarwal <[email protected]> Co-authored-by: Gaurav Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues in TCP QEMU Demo
Description
Test Steps
TCP_Echo_QEMU_mps2 Demo is run with these modifications successfully.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.