-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Create SMP on target test framework. #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SMP on target test framework. #911
Conversation
62724b2 to
74e4e07
Compare
74e4e07 to
d983564
Compare
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/boards/pico/tests/smp/multiple_tasks_running/main.c
Show resolved
Hide resolved
FreeRTOS/Test/Target/boards/pico/tests/smp/multiple_tasks_running/main.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/boards/pico/tests/smp/multiple_tasks_running/main.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/boards/pico/tests/smp/multiple_tasks_running/main.c
Show resolved
Hide resolved
Dazza0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ActoryOu Thanks for implementing this, this looks very promising. I've left a few comments/questions based on our past experience of integrating the unity test framework into a CI pipeline in ESP-IDF.
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/test_config.h
Outdated
Show resolved
Hide resolved
|
@ActoryOu Thanks for the explanations. This PR LGTM. |
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/test_config.h
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Outdated
Show resolved
Hide resolved
FreeRTOS/Test/Target/tests/smp/multiple_tasks_running/multiple_tasks_running.c
Show resolved
Hide resolved
chinglee-iot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions want to discuss with you:
- Can this test detect the problem that the port fails to launch cores other than tick core?
- The EverRunning tasks do nothing but busy looping. How can we know this test function is run by other cores?
Yes, I think so. If the core fail to be launched, it won't be able to set pxCurrentTCBs[ coreID ] correctly. So the state of task is
We check the if the state is eRunning, which means it's running at the same time on the other cores. We don't really care about what core is the tasks running on. We just check if all tasks created by the test cases are all in eRunning on all other cores. |
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
* update the freertos + TCP demos to use the neew API for getting the UDP pyaload buffer [FreeRTOS_GetUDPPayloadBuffer_ByIPType] (#938) * Add CBMC proof-running GitHub Action (#924) * Added two config options to the FreeRTOSConfig file to get the demo running again. Fixed a typo in a file. Added a section to the link file (#940) * Create SMP on target test framework. (#911) * Fix CBMC proof failures (#946) These were introduced in PR #620. * Make static IP address configurable (#947) * Fix issues in TCP QEMU Demo (#948)
* Add proof for vReceiveRA_ReadReply * Add proof for vReceiveRA * Update test case * Use safeMalloc * Umpdate pxGetNetworkBufferWithDescriptor * Add unit test case for zero prefix option length * Remove unsued parameters
* Framework initialization. * Move testRunner.c to test case subfolder. * Update README doc and formatting. * Add default configurations in test_config.h. * Fix License & formatting check. * Fix typo. * Move setup/teardown functions to main.c file. * Move setup/teardown functions back. * Update README doc. * Patch for comments. * Correct test runner file name. * Move test_config.h to the end of FreeRTOSConfig.h. * Add undef in test_config.h and description in README doc. * Correct the file format. * Fix chinglee-iot comments. * Code review suggestions Signed-off-by: Gaurav Aggarwal <[email protected]> * Fix spell check Signed-off-by: Gaurav Aggarwal <[email protected]> --------- Signed-off-by: Gaurav Aggarwal <[email protected]> Co-authored-by: Gaurav Aggarwal <[email protected]>
Create SMP on target test framework.
Description
Create SMP on target test framework. Including test folders, CMakeLists.txt, template, and first test case.
Test Steps
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.