Fix inaccurate ticks in windows port #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: Sleep() in Windows is not guaranteed to be realtime. Usage of Sleep() was causing ticks in Windows port to be incorrect. Solution: Use Waitable Timer in Windows for more accuracy.
Contributor
|
This is a great change - although currently the change in timing makes some of our self monitoring tests fail as they were tuned to using the current method. We will need to fix up the test timing at the same time as accepting this PR. |
qiutongs
reviewed
Jun 8, 2020
|
|
||
| /* Set the Waitable Timer. The timer is set to run periodically at every | ||
| xWaitTimeBetweenTicks milliseconds. */ | ||
| configASSERT( SetWaitableTimer( hTimer, &liDueTime, xWaitTimeBetweenTicks, NULL, NULL, 0 ) ); |
There was a problem hiding this comment.
Nit-pick: better to separate to two lines for debugging purpose.
Contributor
|
This one has become stale since the Kernel is now a submodule. I recreated it as FreeRTOS/FreeRTOS-Kernel#142 |
alfred2g
pushed a commit
to alfred2g/FreeRTOS
that referenced
this pull request
Feb 22, 2023
* Remove multiple_priorities_no_timeslice_covg, single_priority_no_timeslice_covg and single_priority_timeslice_thread test folders and move the covg utest.c to the folder with same FreeRTOSConfig.h * Add configUSE_TICKLESS_IDLE config in single_priority_no_timeslice test group * Add configUSE_MINIMAL_IDLE_HOOK config in single_priority_timeslice test group
alfred2g
pushed a commit
to alfred2g/FreeRTOS
that referenced
this pull request
Feb 22, 2023
* Remove multiple_priorities_no_timeslice_covg, single_priority_no_timeslice_covg and single_priority_timeslice_thread test folders and move the covg utest.c to the folder with same FreeRTOSConfig.h * Add configUSE_TICKLESS_IDLE config in single_priority_no_timeslice test group * Add configUSE_MINIMAL_IDLE_HOOK config in single_priority_timeslice test group
urutva
pushed a commit
to urutva/FreeRTOS
that referenced
this pull request
Aug 29, 2023
* Fix Pico compile warning -- port layer * Warning resolved for volatile discard task.c (FreeRTOS#5) --------- Co-authored-by: Pranjal Chanda <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause: Sleep() in Windows is not guaranteed to be realtime. Usage of Sleep()
was causing ticks in Windows port to be incorrect.
Solution: Use Waitable Timer in Windows for more accuracy.