Connections sharing demo reconnect and TLS #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muneebahmed10
force-pushed
the
multi-reconnect
branch
from
ef1202a to
4cd4579
Compare
yourslab
reviewed
Oct 1, 2020
FreeRTOS-Plus/Demo/FreeRTOS-IoT-Libraries-LTS-Beta2/mqtt/mqtt_multitask/demo_config.h
Outdated
Show resolved
Hide resolved
yourslab
reviewed
Oct 1, 2020
| xResult = MQTT_Publish( &globalMqttContext, xFoundAck.xOriginalCommand.pxCmdContext->pxPublishInfo, packetId ); | ||
| } | ||
|
|
||
| packetId = MQTT_PublishToResend( &globalMqttContext, &cursor ); |
Contributor
There was a problem hiding this comment.
Nit: As there are two calls to MQTT_PublishToResend with the same parameters, would it be possible to use a do...while instead?
Contributor
Author
There was a problem hiding this comment.
I don't think a do-while can be used since the publish should execute 0 or more times, not 1 or more, and I think adding an extra if check for a 0 packet ID looks worse than just keeping this.
yourslab
reviewed
Oct 1, 2020
| democonfigMQTT_BROKER_ENDPOINT, | ||
| democonfigMQTT_BROKER_PORT, | ||
| mqttexampleTRANSPORT_SEND_RECV_TIMEOUT_MS, | ||
| mqttexampleTRANSPORT_SEND_RECV_TIMEOUT_MS ); |
Contributor
There was a problem hiding this comment.
Maybe define the transport timeout depending on whether a plaintext vs TLS connection is used.
Contributor
Author
There was a problem hiding this comment.
Does it need to be different? We use 200 for both the plaintext and mutual auth demos. It was 20 before was that I was only testing against localhost, and I forgot to increase it
sarenameas
reviewed
Oct 1, 2020
| /* Retrieve the operation but do not remove it from the list. */ | ||
| xFoundAck = prvGetAwaitingOperation( packetId, false ); | ||
|
|
||
| if( xFoundAck.usPacketId == packetId ) |
Contributor
There was a problem hiding this comment.
Should this be: if( xFoundAck.usPacketId != MQTT_PACKET_ID_INVALID ) instead?
Contributor
Author
There was a problem hiding this comment.
Doesn't really matter since xFoundAck.usPacketId will be either packetId or 0, so I can change it to != MQTT_PACKET_ID_INVALID if you prefer that over == packetId
| * the subscription list, so tasks do not unexpectedly lose their subscriptions. */ | ||
| if( !xCleanSession && !xSessionPresent ) | ||
| { | ||
| int32_t i = 0, j = 0; |
Contributor
There was a problem hiding this comment.
Isn't part of the FreeRTOS coding style to not use i and j and use like lPendingAckIndex and lSubscriptionIndex?
Contributor
Author
There was a problem hiding this comment.
I'm unsure on that, but I feel like using i and j as indices is so ubiquitous that it shouldn't matter. I prefer leaving them, but will rename them if you prefer.
...s/Demo/FreeRTOS-IoT-Libraries-LTS-Beta2/mqtt/mqtt_multitask/DemoTasks/MultitaskMQTTExample.c
Outdated
Show resolved
Hide resolved
...s/Demo/FreeRTOS-IoT-Libraries-LTS-Beta2/mqtt/mqtt_multitask/DemoTasks/MultitaskMQTTExample.c
Outdated
Show resolved
Hide resolved
...s/Demo/FreeRTOS-IoT-Libraries-LTS-Beta2/mqtt/mqtt_multitask/DemoTasks/MultitaskMQTTExample.c
Outdated
Show resolved
Hide resolved
| * "...base64 data...\n"\ | ||
| * "-----END RSA PRIVATE KEY-----\n" | ||
| * | ||
| * #define democonfigCLIENT_PRIVATE_KEY_PEM "...insert here..." |
Contributor
There was a problem hiding this comment.
Is it a requirement to do this demo with mutual auth?
Contributor
Author
There was a problem hiding this comment.
I think it would make sense for someone to want to test this against AWS IoT, so that's why I added mutual auth instead of just server auth.
FreeRTOS-Plus/Demo/FreeRTOS-IoT-Libraries-LTS-Beta2/mqtt/mqtt_multitask/demo_config.h
Outdated
Show resolved
Hide resolved
sarenameas
reviewed
Oct 1, 2020
...s/Demo/FreeRTOS-IoT-Libraries-LTS-Beta2/mqtt/mqtt_multitask/DemoTasks/MultitaskMQTTExample.c
Outdated
Show resolved
Hide resolved
Co-authored-by: SarenaAWS <[email protected]> Co-authored-by: Oscar Michael Abrina <[email protected]>
sarenameas
approved these changes
Oct 2, 2020
n9wxu
approved these changes
Oct 2, 2020
muneebahmed10
added a commit
to muneebahmed10/FreeRTOS
that referenced
this pull request
Oct 2, 2020
muneebahmed10
added a commit
that referenced
this pull request
Oct 3, 2020
moninom1
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify * parent be9fe45d8ec440f7750de0f4870b28de39b10a3b author Hein Tibosch <[email protected]> 1609879469 +0800 committer Aniruddha Kanhere <[email protected]> 1619029134 -0700 Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> Fix doxygen check (#149) * Update doxygen version * update the config file TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> fix deprecated volatile compound assignment (#152) * fixed deprecated volatile compound assignment C++20 deprecates some undefined or unclear use cases of 'volatile' like compound assignments and compliant compilers warn about those deprecated operations. In vStreamBufferMoveMid the deprecated compound assignment and other direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a local variable stored back when done. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> FreeRTOS_ARP.c : store local addresses only (#120) * FreeRTOS_ARP.c : store local addresses only * Added the function xARPWaitResolution() * Added an entry to lexicon.txt. * Ran Uncrustify * Update unit test file * Update * Declared xARPWaitResolution() in FreeRTOS_IP.h * Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0 Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> Fix doxygen check (#149) * Update doxygen version * update the config file TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify Create uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml Update uncrustify.yml * Remove unused file Include ICMP while calculating IP header checksum (#198) * Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify * Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> * Fix doxygen check (#149) * Update doxygen version * update the config file * TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix deprecated volatile compound assignment (#152) * fixed deprecated volatile compound assignment C++20 deprecates some undefined or unclear use cases of 'volatile' like compound assignments and compliant compilers warn about those deprecated operations. In vStreamBufferMoveMid the deprecated compound assignment and other direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a local variable stored back when done. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * FreeRTOS_ARP.c : store local addresses only (#120) * FreeRTOS_ARP.c : store local addresses only * Added the function xARPWaitResolution() * Added an entry to lexicon.txt. * Ran Uncrustify * Update unit test file * Update * Declared xARPWaitResolution() in FreeRTOS_IP.h * Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0 Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes * Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> * Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. * Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> * Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment * Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify * Include ICMP checksum * Uncrustify * Update ci.yml * Spell check Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Mark Tuttle <[email protected]> Co-authored-by: Mark R. Tuttle <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Hartmut Schaefer <[email protected]> Co-authored-by: evpopov <[email protected]> Co-authored-by: Emil Popov <[email protected]> Co-authored-by: shrewmouse1 <[email protected]> Co-authored-by: Paul Bartell <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: alfred gedeon <[email protected]> Add comment to CI.yml fix compiler warnings about casting to format string (#197) * fix compiler warnings about casting to format string Fix various warnings like: /FreeRTOS-Plus-TCP/FreeRTOS_IP.c: In function 'FreeRTOS_strerror_r': /FreeRTOS-Plus-TCP/FreeRTOS_IP.c:3395:60: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=] ( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int32_t ) xErrnum ); ~^ ~~~~~~~~~~~~~~~~~~~ %ld * explicitly cast arguments to format string This should hopefully make the format string compatible with all architectures. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Added git-secrets check to Github actions (#201) Add header file to socket.h so that it can be compiled on its own (#204) * Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify * Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> * Fix doxygen check (#149) * Update doxygen version * update the config file * TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix deprecated volatile compound assignment (#152) * fixed deprecated volatile compound assignment C++20 deprecates some undefined or unclear use cases of 'volatile' like compound assignments and compliant compilers warn about those deprecated operations. In vStreamBufferMoveMid the deprecated compound assignment and other direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a local variable stored back when done. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * FreeRTOS_ARP.c : store local addresses only (#120) * FreeRTOS_ARP.c : store local addresses only * Added the function xARPWaitResolution() * Added an entry to lexicon.txt. * Ran Uncrustify * Update unit test file * Update * Declared xARPWaitResolution() in FreeRTOS_IP.h * Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0 Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes * Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> * Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. * Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> * Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment * Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify * Create uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Add header in the socket file * Remove unwanted file * remove unwanted changes Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Mark Tuttle <[email protected]> Co-authored-by: Mark R. Tuttle <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Hartmut Schaefer <[email protected]> Co-authored-by: evpopov <[email protected]> Co-authored-by: Emil Popov <[email protected]> Co-authored-by: shrewmouse1 <[email protected]> Co-authored-by: Paul Bartell <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: alfred gedeon <[email protected]> User hook function for handling unsupported Ethernet frames (#200) * Adds an optional user hook that gets called for all unhandled Ethernet frames. * re-wording * Fix spell check Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Limit the number of attempts to resolve an address in xARPWaitResolution() (#206) Co-authored-by: Hein Tibosch <[email protected]> Update litani submodule to version 1.6.0 (#210) [CBMC] Add assert with readability check (#214) * Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify * Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> * Fix doxygen check (#149) * Update doxygen version * update the config file * TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix deprecated volatile compound assignment (#152) * fixed deprecated volatile compound assignment C++20 deprecates some undefined or unclear use cases of 'volatile' like compound assignments and compliant compilers warn about those deprecated operations. In vStreamBufferMoveMid the deprecated compound assignment and other direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a local variable stored back when done. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * FreeRTOS_ARP.c : store local addresses only (#120) * FreeRTOS_ARP.c : store local addresses only * Added the function xARPWaitResolution() * Added an entry to lexicon.txt. * Ran Uncrustify * Update unit test file * Update * Declared xARPWaitResolution() in FreeRTOS_IP.h * Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0 Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes * Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> * Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. * Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> * Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment * Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify * Create uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update proof to use assert with readability check * Revert ci.yml changes * Remove unwanted changes * Null check * Fix adding NULL checks * Uncrustify Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Mark Tuttle <[email protected]> Co-authored-by: Mark R. Tuttle <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Hartmut Schaefer <[email protected]> Co-authored-by: evpopov <[email protected]> Co-authored-by: Emil Popov <[email protected]> Co-authored-by: shrewmouse1 <[email protected]> Co-authored-by: Paul Bartell <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: alfred gedeon <[email protected]> Add unit-tests for FreeRTOS_ARP.c (#209) * Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify * Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> * Fix doxygen check (#149) * Update doxygen version * update the config file * TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix deprecated volatile compound assignment (#152) * fixed deprecated volatile compound assignment C++20 deprecates some undefined or unclear use cases of 'volatile' like compound assignments and compliant compilers warn about those deprecated operations. In vStreamBufferMoveMid the deprecated compound assignment and other direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a local variable stored back when done. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * FreeRTOS_ARP.c : store local addresses only (#120) * FreeRTOS_ARP.c : store local addresses only * Added the function xARPWaitResolution() * Added an entry to lexicon.txt. * Ran Uncrustify * Update unit test file * Update * Declared xARPWaitResolution() in FreeRTOS_IP.h * Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0 Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes * Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> * Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. * Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> * Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment * Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify * Create uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Add header in the socket file * Remove unwanted file * remove unwanted changes * First commit * Cleanup * Update: working version * Coverage of eARPGetCacheEntry * Update * Unit-test and clenaup * 100% line and function coverage * Uncrustify and update * 100% all coverage * Move files to correct location * Fix tests * uncrustified * Update ci.yml * Update * uncrustify and update after Hein's comments * Empty commit * Clenaup after @yanjos-dev's review * Update CI * Cleanup - pass 1 * Remove gdb * Uncrustify * Remove litani changes * Clean up * Uncrustify Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Mark Tuttle <[email protected]> Co-authored-by: Mark R. Tuttle <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Hartmut Schaefer <[email protected]> Co-authored-by: evpopov <[email protected]> Co-authored-by: Emil Popov <[email protected]> Co-authored-by: shrewmouse1 <[email protected]> Co-authored-by: Paul Bartell <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: alfred gedeon <[email protected]> DHCP unit test (#211) Co-authored-by: Aniruddha Kanhere <[email protected]> Repair buffer leak when replying to NBNS requests (#215) * Repair buffer leak when replying to NBNS requests * Applied Uncrustify * Variable 'pxNewBuffer' was out of scope Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Static allocation, if configSUPPORT_STATIC_ALLOCATION == 1 (#208) (#217) * Static allocation of tasks and queues, if configSUPPORT_STATIC_ALLOCATION == 1 (#208) Is not added to any ported network interfaced. * Build-check fix * Uncrustify * Uncrustify v2 * Update FreeRTOS_IP.c Co-authored-by: Christian Jensen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Add a method to obtain the handle of the FreeRTOS+TCP IP task (#222) * Add a method to obtain the handle of the FreeRTOS+TCP IP task * Added the modified FreeRTOS_IP.c * Update lexicon.txt Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Code changes for unit-testing (#223) * Fix compiler warnings when the TCP Window is not used (#124) * Fix warnings when TCP window is not used * Uncrustify * Move local variables to inner loop in prvNetworkInterfaceInput() (#144) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update litani submodule (#147) Co-authored-by: Mark R. Tuttle <[email protected]> * Fix doxygen check (#149) * Update doxygen version * update the config file * TCP_WIN: fix compile warning on x86_64 (#148) * TCP_WIN: fix compile warning on x86_64 Fix the following warning when building for 64 bit: warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] uint32_t ulReturn = ~0UL; ^ * Update FreeRTOS_TCP_WIN.c Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix deprecated volatile compound assignment (#152) * fixed deprecated volatile compound assignment C++20 deprecates some undefined or unclear use cases of 'volatile' like compound assignments and compliant compilers warn about those deprecated operations. In vStreamBufferMoveMid the deprecated compound assignment and other direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a local variable stored back when done. * Uncrustify Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * FreeRTOS_ARP.c : store local addresses only (#120) * FreeRTOS_ARP.c : store local addresses only * Added the function xARPWaitResolution() * Added an entry to lexicon.txt. * Ran Uncrustify * Update unit test file * Update * Declared xARPWaitResolution() in FreeRTOS_IP.h * Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0 Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Remove unnecessary #ifndef (#186) * Add entropy * remove warning * Remove unnecessary ifndef * Remove unwanted changes * Don't Fragment Flags patch. (#179) * Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols Adds definitions for the IP fragmentation flags Modifies the fragmentation check for incoming frames to drop both the first and later fragments. Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP ) Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments. * Uncrustified * Uncrustify * Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 ) Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere * Adds the 'U' qualifier as requested by hs2gh fixes a typo in FreeRTOSIPConfigDefaults.h * Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion. * Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT * same as last commit, simply forgot to save this before pushing. Co-authored-by: Emil Popov <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * fix IP buffer padding check on 64bit (#146) * fix IP buffer padding check on 64bit On 64 bit systems, FreeRTOS_IPInit() would assert ipconfigBUFFER_PADDING was equal to 14 to "make sure there is enough space in pucEthernetBuffer to store a pointer." This prevents the driver from requesting additional padding, so make the assert greater than or equal to 14. Also use the final ipBUFFER_PADDING value instead of ipconfigBUFFER_PADDING, which is probably what was intended? * Update after comments Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Update readme.md (#189) Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage. I had a tough time reading that table until I looked at the md source. You could also just put code fences around it: ~~~ /** * RAM area H747 H743 H742 Location * ------------------------------------------------ * DTCM 128k 128k 128k 0x20000000 * AXI-SRAM 511k 511k 384k 0x24000000 * * SRAM1 128k 128k 32k 0x30000000 * SRAM2 128k 128k 16k 0x30020000 * SRAM3 32k 32k - 0x30040000 * SRAM4 64k 64k 64k 0x38000000 * Backup SRAM 4k 4k 4k 0x38800000 */ ~~~ Co-authored-by: Aniruddha Kanhere <[email protected]> * Update files referencing aws_application_version.h to use iot_application_version.h (#188) * Update files referencing aws_application_version.h to use iot_application_version.h * Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository. * Remove function defs from header files (#190) * Add entropy * remove warning * Remove function defs from headers * Some corrections * More fixes and uncrustify * Remove the BaseType min function * Doxygen * Fix one CBMC proof * More cbmc proof fixes * More cbmc fixes * Some doxygen additions * Update last CBMC proof * Doxygen comments * Doxygen updates * Doxygen and spell check * Spell check and unit-test * Unit test fix * Update after comments * Update 2 after comments * Move function around * Uncrustify * Update after comments Co-authored-by: Gary Wicker <[email protected]> * Do not release a network buffer if it equals to NULL (#191) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Circumvent Qemu MPS2 networking bug (#142) * Add support for MPS2 networking with lan9118/lan9220 * Fix uncrustify errors * Enable network interrupt handling * Add network interrupt support to Qemu MPS2 AN385 * Fix function comment * Fix Uncrustify errors * Fix Uncrustify errors * Fix Uncrustify Errors * Fix typo * Cirumvent Qemu MPS2 network bug * Remove commented code, add doxygen comment * Add a project for static analysis (#195) * Add entropy * remove warning * Remove unwanted changes * Update tcp_mem_stats.c * Add Coverity * Remove unused files * Add some features * clean up * More clean up * Unwanted additions removal * Clean up * Add 32-bit compile option * Update after comments * Uncrustify * Create uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Update uncrustify.yml * Make some code changes as a precursor for unit-testing * remove unused file * Fixed failing checks * Fixed CBMC proof Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Mark Tuttle <[email protected]> Co-authored-by: Mark R. Tuttle <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Thomas Pedersen <[email protected]> Co-authored-by: Hartmut Schaefer <[email protected]> Co-authored-by: evpopov <[email protected]> Co-authored-by: Emil Popov <[email protected]> Co-authored-by: shrewmouse1 <[email protected]> Co-authored-by: Paul Bartell <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: alfred gedeon <[email protected]> Use an infinite timeout in FreeRTOS_closesocket when called from a user task (#226) Reformat MPS2_AN385 network driver (#224) * Update the MPS2_AN385 network driver so it conforms to the +TCP coding and style guide. * Update smsc9220_eth_drv.c Remove #warning message erroneously left in. Co-authored-by: alfred gedeon <[email protected]> Uncrustify. Uncrustify again. Before sending a challenge ACK, check the sequence number more properly (#225) * Before sending a challenge ACK, check the sequence number more properly * Make xSequenceLessThan and xSequenceGreaterThan public functions * Extended comments on two public functions. * Fix Spell check * Although no changes were made to MPS2_AN385, some formatting changes to that driver Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Fix Some warnings * merge tcp_mem_stats * Disallow octal IP-addresses * Uncrustified * Clear the output variable * Add unit-tests for pton4 * Uncrustified * Updated log messages Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: